dnkl/foot
41
2.0k
Fork
You've already forked foot
242

ime: refresh search matches after IME commit #2389

Open
0WD0 wants to merge 1 commit from 0wd0/ime-search-refresh into master AGit
pull from: 0wd0/ime-search-refresh
merge into: dnkl:master
dnkl:master
dnkl:osc-5522
dnkl:sixel-heap-buffer-overflow
dnkl:releases/1.27
dnkl:releases/1.26
dnkl:releases/1.25
dnkl:releases/1.24
dnkl:multi-cursor
dnkl:releases/1.23
dnkl:pixman-16f-2
dnkl:releases/1.22
dnkl:releases/1.21
dnkl:releases/1.20
dnkl:releases/1.19
dnkl:releases/1.18
dnkl:releases/1.17
dnkl:releases/1.16
dnkl:releases/1.15
dnkl:releases/1.14
dnkl:releases/1.13
dnkl:releases/1.12
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
First-time contributor
Copy link

Fixes scrollback search not highlighting matches after IME commit (e.g. CJK input).

Fixes scrollback search not highlighting matches after IME commit (e.g. CJK input).
ime: refresh search matches after IME commit
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
1789924171 
The IME commit handler appended text to the search buffer and refreshed
the search box, but never called search_find_next(). CJK input into
scrollback search therefore showed no match until another key press
re-triggered the regular search input path. Call search_find_next() in
the commit branch, and apply the same fix to unicode-mode.c. To allow
this, search_find_next() is no longer static.
@ -61,2 +60,3 @@
if (term->is_searching) {
search_add_chars(term, utf8, chars);
else
search_find_next(term, SEARCH_BACKWARD_SAME_POSITION);
Owner
Copy link

Do we need a render_refresh_search() too?

Do we need a `render_refresh_search()` too?
Author
First-time contributor
Copy link

Nop. There are unicode_mode_deactivate -> unicode_mode_updated -> render_refresh_search already.

Nop. There are `unicode_mode_deactivate` -> `unicode_mode_updated` -> `render_refresh_search` already.
0WD0 marked this conversation as resolved
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/2389/head:0wd0/ime-search-refresh
git switch 0wd0/ime-search-refresh

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff 0wd0/ime-search-refresh
git switch 0wd0/ime-search-refresh
git rebase master
git switch master
git merge --ff-only 0wd0/ime-search-refresh
git switch 0wd0/ime-search-refresh
git rebase master
git switch master
git merge --no-ff 0wd0/ime-search-refresh
git switch master
git merge --squash 0wd0/ime-search-refresh
git switch master
git merge --ff-only 0wd0/ime-search-refresh
git switch master
git merge 0wd0/ime-search-refresh
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/foot!2389
Reference in a new issue
dnkl/foot
No description provided.
Delete branch "0wd0/ime-search-refresh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?