dnkl/foot
41
2.0k
Fork
You've already forked foot
243

sixel: clamp max width/height in 'CSI ? 2 ; 3 ; W ; H S' #2355

Open
dnkl wants to merge 1 commit from sixel-heap-buffer-overflow into master
pull from: sixel-heap-buffer-overflow
merge into: dnkl:master
dnkl:master
dnkl:osc-5522
dnkl:releases/1.27
dnkl:releases/1.26
dnkl:releases/1.25
dnkl:releases/1.24
dnkl:multi-cursor
dnkl:releases/1.23
dnkl:pixman-16f-2
dnkl:releases/1.22
dnkl:releases/1.21
dnkl:releases/1.20
dnkl:releases/1.19
dnkl:releases/1.18
dnkl:releases/1.17
dnkl:releases/1.16
dnkl:releases/1.15
dnkl:releases/1.14
dnkl:releases/1.13
dnkl:releases/1.12
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Owner
Copy link

This ensures the user cannot raise the maximum sixel size, where width*height cannot be represented as an integer.

Note, we should consider moving all sixel width/height variables from int to size_t. But, since it doesn't make any sense with overly large
sixel images, clamping the max width/height is enough. Add a static_assert() that checks SIXEL_MAX_WIDTH * SIXEL_MAX_HEIGHT doesn't overflow.

Closes #2343

This ensures the user cannot raise the maximum sixel size, where width*height cannot be represented as an integer. Note, we should consider moving all sixel width/height variables from int to size_t. But, since it doesn't make any sense with overly large sixel images, clamping the max width/height is enough. Add a `static_assert()` that checks `SIXEL_MAX_WIDTH * SIXEL_MAX_HEIGHT` doesn't overflow. Closes #2343
sixel: clamp max width/height in 'CSI ? 2 ; 3 ; W ; H S'
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pull_request_metadata/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
f51d84b28f
 
This ensures the user cannot raise the maximum sixel size, where
width*height cannot be represented as an integer.
Note, we should consider moving all sixel width/height variables from
int to size_t. But, since it doesn't make any sense with overly large
sixel images, clamping the max width/height is enough. Add a
static_assert() that checks SIXEL_MAX_WIDTH * SIXEL_MAX_HEIGHT doesn't
overflow.
dnkl force-pushed sixel-heap-buffer-overflow from f51d84b28f
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pull_request_metadata/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
to 70ed9850cc
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
2026年05月22日 11:30:45 +02:00 Compare
dnkl force-pushed sixel-heap-buffer-overflow from 70ed9850cc
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
to 8380564e4c
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
2026年05月22日 11:47:19 +02:00 Compare
dnkl force-pushed sixel-heap-buffer-overflow from 8380564e4c
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
to 92187d2e4e
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
2026年05月22日 11:50:47 +02:00 Compare
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
builds.sr.ht/freebsd-x64 Job completed
ci/woodpecker/pr/woodpecker Pipeline was successful
This pull request has changes conflicting with the target branch.
  • CHANGELOG.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin sixel-heap-buffer-overflow:sixel-heap-buffer-overflow
git switch sixel-heap-buffer-overflow

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff sixel-heap-buffer-overflow
git switch sixel-heap-buffer-overflow
git rebase master
git switch master
git merge --ff-only sixel-heap-buffer-overflow
git switch sixel-heap-buffer-overflow
git rebase master
git switch master
git merge --no-ff sixel-heap-buffer-overflow
git switch master
git merge --squash sixel-heap-buffer-overflow
git switch master
git merge --ff-only sixel-heap-buffer-overflow
git switch master
git merge sixel-heap-buffer-overflow
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/foot!2355
Reference in a new issue
dnkl/foot
No description provided.
Delete branch "sixel-heap-buffer-overflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?