dnkl/foot
41
2.0k
Fork
You've already forked foot
243

WIP: config: add curly-underline-height #2280

Draft
sv wants to merge 1 commit from sv/foot:underline-height into master
pull from: sv/foot:underline-height
merge into: dnkl:master
dnkl:master
dnkl:osc-5522
dnkl:sixel-heap-buffer-overflow
dnkl:releases/1.27
dnkl:releases/1.26
dnkl:releases/1.25
dnkl:releases/1.24
dnkl:multi-cursor
dnkl:releases/1.23
dnkl:pixman-16f-2
dnkl:releases/1.22
dnkl:releases/1.21
dnkl:releases/1.20
dnkl:releases/1.19
dnkl:releases/1.18
dnkl:releases/1.17
dnkl:releases/1.16
dnkl:releases/1.15
dnkl:releases/1.14
dnkl:releases/1.13
dnkl:releases/1.12
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
First-time contributor
Copy link

Kind of works, but I am not entirely happy with how the underlines are rendered.

Bold text makes it harder, I wonder if we should use the same underline thickness irrespective of the font weight.

Kind of works, but I am not entirely happy with how the underlines are rendered. Bold text makes it harder, I wonder if we should use the same underline thickness irrespective of the font weight.
config: add curly-underline-height
Some checks are pending
builds.sr.ht/freebsd-x64 Job running...
c788b4b56a
Some checks are pending
builds.sr.ht/freebsd-x64 Job running...
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u underline-height:sv-underline-height
git switch sv-underline-height

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff sv-underline-height
git switch sv-underline-height
git rebase master
git switch master
git merge --ff-only sv-underline-height
git switch sv-underline-height
git rebase master
git switch master
git merge --no-ff sv-underline-height
git switch master
git merge --squash sv-underline-height
git switch master
git merge --ff-only sv-underline-height
git switch master
git merge sv-underline-height
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/foot!2280
Reference in a new issue
dnkl/foot
No description provided.
Delete branch "sv/foot:underline-height"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?