dnkl/foot
41
2.0k
Fork
You've already forked foot
243

wayland: use wl_shm v2 if available #1772

Manually merged
dnkl merged 1 commit from shm-v2 into master 2024年07月18日 08:44:19 +02:00
Owner
Copy link
No description provided.
dnkl force-pushed shm-v2 from 277133fdba
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pr/woodpecker Pipeline was successful
to 4f25e1ba9f
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
2024年07月18日 08:23:33 +02:00 Compare
dnkl manually merged commit 4f25e1ba9f into master 2024年07月18日 08:44:18 +02:00
First-time contributor
Copy link

Hi,

Not sure, but maybe need to wrap a few more lines with the new ifdef ?
Something like -

+#if defined(WL_SHM_RELEASE_SINCE_VERSION)
 wayl->use_shm_release = version >= WL_SHM_RELEASE_SINCE_VERSION;
+#else
+ wayl->use_shm_release = false;
+#endif

 if (wayl->shm != NULL) {
+#if defined(WL_SHM_RELEASE_SINCE_VERSION)
 if (wayl->use_shm_release)
 wl_shm_release(wayl->shm);
 else
+#endif
 wl_shm_destroy(wayl->shm);

thx always,
-m

Hi, Not sure, but maybe need to wrap a few more lines with the new ifdef ? Something like - ``` +#if defined(WL_SHM_RELEASE_SINCE_VERSION) wayl->use_shm_release = version >= WL_SHM_RELEASE_SINCE_VERSION; +#else + wayl->use_shm_release = false; +#endif ``` ``` if (wayl->shm != NULL) { +#if defined(WL_SHM_RELEASE_SINCE_VERSION) if (wayl->use_shm_release) wl_shm_release(wayl->shm); else +#endif wl_shm_destroy(wayl->shm); ``` thx always, -m
Author
Owner
Copy link

@mckellygit yes, absolutely necessary. Fixed in e11a4ab6af

@mckellygit yes, absolutely necessary. Fixed in https://codeberg.org/dnkl/foot/commit/e11a4ab6af29cb841feaf2cf4785cfd1a3d709fd
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/foot!1772
Reference in a new issue
dnkl/foot
No description provided.
Delete branch "shm-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?