12
168
Fork
You've already forked fnott
32

initial support for placeholders in selection-helper #204

Open
ladams wants to merge 1 commit from ladams/fnott:select_placeholders into master
pull from: ladams/fnott:select_placeholders
merge into: dnkl:master
dnkl:master
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:release/1.4
dnkl:parse-font-apply-fontconfig-rules
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
First-time contributor
Copy link

The current implementation is more of a demo. It only supports
placeholders that are surrounded by whitespace (or the end of the
command). Nevertheless, the functionality is quite nice. E.g.:
selection-helper=fuzzel --dmenu0 --mesg %s

I am opening this PR to start discussion about whether this feature is appropriate for fnott, and how it should be implemented. I won't be offended if this particular code doesn't get merged; I just find it easier to discuss design with a minimal implementation.

The current implementation is more of a demo. It only supports placeholders that are surrounded by whitespace (or the end of the command). Nevertheless, the functionality is quite nice. E.g.: selection-helper=fuzzel --dmenu0 --mesg %s I am opening this PR to start discussion about whether this feature is appropriate for fnott, and how it should be implemented. I won't be offended if this particular code doesn't get merged; I just find it easier to discuss design with a minimal implementation.
initial support for placeholders in selection-helper
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
builds.sr.ht/freebsd-x64 Job completed
75be724ae5 
The current implementation is more of a demo. It only supports
placeholders that are surrounded by whitespace (or the end of the
command). Nevertheless, the functionality is quite nice. E.g.:
selection-helper=fuzzel --dmenu0 --mesg %s
Author
First-time contributor
Copy link

Bump

Bump
Author
First-time contributor
Copy link

Bump

Bump
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
builds.sr.ht/freebsd-x64 Job completed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u select_placeholders:ladams-select_placeholders
git switch ladams-select_placeholders

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff ladams-select_placeholders
git switch ladams-select_placeholders
git rebase master
git switch master
git merge --ff-only ladams-select_placeholders
git switch ladams-select_placeholders
git rebase master
git switch master
git merge --no-ff ladams-select_placeholders
git switch master
git merge --squash ladams-select_placeholders
git switch master
git merge --ff-only ladams-select_placeholders
git switch master
git merge ladams-select_placeholders
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/fnott!204
Reference in a new issue
dnkl/fnott
No description provided.
Delete branch "ladams/fnott:select_placeholders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?