12
168
Fork
You've already forked fnott
32

notification: implement additional progress bar customization #199

Open
sewn wants to merge 1 commit from sewn/fnott:master into master
pull from: sewn/fnott:master
merge into: dnkl:master
dnkl:master
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:release/1.4
dnkl:parse-font-apply-fontconfig-rules
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Contributor
Copy link

Introduce 3 configuration options to customize the inner color,
border size, and the padding of the progress indicator.

Introduce 3 configuration options to customize the inner color, border size, and the padding of the progress indicator.
notification: implement additional progress bar customization
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
builds.sr.ht/freebsd-x64 Job completed
1df77f971a
 
Introduce 3 configuration options to customize the inner color,
border size, and the padding of the progress indicator.
dnkl left a comment
Copy link

Tested, and overall, looks good.

Tested, and overall, looks good.
@ -239,0 +241,4 @@
same color and size of the notification. Default: _yes_.
*progress-bar-inner-color*
Inner color, in RGBA format, of progress indicator. Default: _00000000_.
Owner
Copy link

"inner" is ambiguous; does it refer to the color of the progressed part, or the remaining part? I thought it was the progressed part, but it turned out to be the remaining part (yes, now I know we already have a progress-color option...).

Can we rename it to e.g. progress-background?

Since the already existing option, progress-color doesn't have bar in its name, I would suggest removing it from the new options as well.

So:

  • progress-border
  • progress-padding
  • progress-background
_"inner"_ is ambiguous; does it refer to the color of the progressed part, or the remaining part? I thought it was the progressed part, but it turned out to be the remaining part (yes, _now_ I know we already have a `progress-color` option...). Can we rename it to e.g. `progress-background`? Since the already existing option, `progress-color` doesn't have `bar` in its name, I would suggest removing it from the new options as well. So: * `progress-border` * `progress-padding` * `progress-background`
Author
Contributor
Copy link

I find that quite misleading as the padding, border and background of the progress are unused for when the progress bar style is set to the background, but sure.

I find that quite misleading as the padding, border and background of the progress are unused for when the progress bar style is set to the background, but sure.
sewn force-pushed master from 1df77f971a
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
builds.sr.ht/freebsd-x64 Job completed
to 911bb412ab
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
builds.sr.ht/freebsd-x64 Job completed
2026年05月28日 16:22:33 +02:00 Compare
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job completed
builds.sr.ht/freebsd-x64 Job completed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u master:sewn-master
git switch sewn-master

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff sewn-master
git switch sewn-master
git rebase master
git switch master
git merge --ff-only sewn-master
git switch sewn-master
git rebase master
git switch master
git merge --no-ff sewn-master
git switch master
git merge --squash sewn-master
git switch master
git merge --ff-only sewn-master
git switch master
git merge sewn-master
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/fnott!199
Reference in a new issue
dnkl/fnott
No description provided.
Delete branch "sewn/fnott:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?