12
167
Fork
You've already forked fnott
32

icon: search by icon's name #131

Closed
evyatar wants to merge 1 commit from evyatar:icon-search into master
pull from: evyatar:icon-search
merge into: dnkl:master
dnkl:master
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:release/1.4
dnkl:parse-font-apply-fontconfig-rules
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Contributor
Copy link

This will make fnott search for icons by their names in addition to their path name.

Some icon themes use the name of the theme rather than their paths in their inheritance list which resulted in fnott not finding the correct themes to inherit from.

This also makes it possible to specify the theme name in fnott.ini similar to GTK's settings.ini

This will make fnott search for icons by their names in addition to their path name. Some icon themes use the name of the theme rather than their paths in their inheritance list which resulted in fnott not finding the correct themes to inherit from. This also makes it possible to specify the theme name in fnott.ini similar to GTK's settings.ini
icon: search by icon's name
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
5f481ce07f
Author
Contributor
Copy link

Missed this part of the spec:

the list of base directories and the internal name of the current theme

I though by "internal" they meant the Name field, but:

The internal name of the theme is the name of the subdirectory

Missed this part of the spec: > the list of base directories and the internal name of the current theme I though by "internal" they meant the Name field, but: > The internal name of the theme is the name of the subdirectory
evyatar closed this pull request 2024年07月14日 11:51:15 +02:00
Author
Contributor
Copy link

However, some themes use spaces in the Inherits list for example:

Inherits=breeze-dark, hicolor

fnott will try to load a directory named hicolor (with a space in the beginning).
but since internal names can't have spaces, I think the strtok() should treat spaces as delimiters too, thoughts?

However, some themes use spaces in the Inherits list for example: `Inherits=breeze-dark, hicolor` fnott will try to load a directory named ` hicolor` (with a space in the beginning). but since internal names can't have spaces, I think the strtok() should treat spaces as delimiters too, thoughts?
Owner
Copy link

I think we can strip spaces, yes.

Technically, these themes are broken; inherits isn't supposed to be a list:

The name of the theme that this theme inherits from.

In addition to that, there's no reason to explicitly include hicolor in inherits, since it's the default fallback.

Anyway, since we already handle lists in inherits, stripping spaces seems like the right thing to do.

I think we can strip spaces, yes. Technically, these themes are broken; `inherits` isn't supposed to be a list: > _The name of the theme that this theme inherits from._ In addition to that, there's no reason to explicitly include `hicolor` in `inherits`, since it's the default fallback. Anyway, since we already handle lists in `inherits`, stripping spaces seems like the right thing to do.
evyatar deleted branch icon-search 2024年07月14日 12:16:45 +02:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/fnott!131
Reference in a new issue
dnkl/fnott
No description provided.
Delete branch "evyatar:icon-search"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?