10
66
Fork
You've already forked fcft
14

Add version functions to the library #62

Open
kpckpc wants to merge 6 commits from kpckpc/fcft:version_info into master
pull from: kpckpc/fcft:version_info
merge into: dnkl:master
dnkl:master
dnkl:colrv1
dnkl:releases/3.3
dnkl:rasterize-utf8
dnkl:spacing
dnkl:releases/3.2
dnkl:releases/3.1
dnkl:releases/3.0
dnkl:releases/2.5
dnkl:releases/2.4
dnkl:releases/2.3
dnkl:releases/2.2
dnkl:releases/2.1
dnkl:releases/2.0
dnkl:releases/1.0
First-time contributor
Copy link

log_version_information benefits from the version functions of other libraries.
Be a nice citizen and also return the favor for users of this library.
Library functions instead of defines, ensure the actual version is displayed. Sometimes headers are out of sync, e.g. when compiling on one machine and copying binary to another.

log_version_information benefits from the version functions of other libraries. Be a nice citizen and also return the favor for users of this library. Library functions instead of defines, ensure the actual version is displayed. Sometimes headers are out of sync, e.g. when compiling on one machine and copying binary to another.
Owner
Copy link

I like the PR in general, however, there are CI failures on this PR. Can you please fix them? Also, not sure if this will show up in the CI, but I'm getting this when configuring the build tree:

../../doc/meson.build:22: WARNING: Newline character in a string detected, use ''' (three single quotes) for multiline strings instead.
This will become a hard error in a future Meson release.
 'fcft_version_string.3.scd]
 ^
../../doc/meson.build:22: WARNING: Newline character in a string detected, use ''' (three single quotes) for multiline strings instead.
This will become a hard error in a future Meson release.
 'fcft_version_string.3.scd]
 ^
../../doc/meson.build:22:73: ERROR: lexer
 'fcft_version_string.3.scd]
 ^
A full log can be found at /home/daniel/src/fcft/bld/debug/meson-logs/meson-log.txt
I like the PR in general, however, there are CI failures on this PR. Can you please fix them? Also, not sure if this will show up in the CI, but I'm getting this when configuring the build tree: ``` ../../doc/meson.build:22: WARNING: Newline character in a string detected, use ''' (three single quotes) for multiline strings instead. This will become a hard error in a future Meson release. 'fcft_version_string.3.scd] ^ ../../doc/meson.build:22: WARNING: Newline character in a string detected, use ''' (three single quotes) for multiline strings instead. This will become a hard error in a future Meson release. 'fcft_version_string.3.scd] ^ ../../doc/meson.build:22:73: ERROR: lexer 'fcft_version_string.3.scd] ^ A full log can be found at /home/daniel/src/fcft/bld/debug/meson-logs/meson-log.txt ```
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u version_info:kpckpc-version_info
git switch kpckpc-version_info

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff kpckpc-version_info
git switch kpckpc-version_info
git rebase master
git switch master
git merge --ff-only kpckpc-version_info
git switch kpckpc-version_info
git rebase master
git switch master
git merge --no-ff kpckpc-version_info
git switch master
git merge --squash kpckpc-version_info
git switch master
git merge --ff-only kpckpc-version_info
git switch master
git merge kpckpc-version_info
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/fcft!62
Reference in a new issue
dnkl/fcft
No description provided.
Delete branch "kpckpc/fcft:version_info"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?