1
3
Fork
You've already forked crpath
1

Patch 1.1.2 to fix issue #10 in version 1.1. #11

Merged
croil merged 1 commit from fix10 into main1_1_0 2026年04月08日 14:29:17 +02:00
Owner
Copy link

This patch fixes the segmentation fault discovered in _accumpart() due to incorrect usage of _cpyif() by adding an offset parameter to _cpyif() so that the intent of setting buf to NULL can be cleanly transmitted to the test in _cpyif(). It was decided that this is less brittle than simply testing buf in one case because the offset parameter cannot be forgotten without causing a compile error, whereas the test can be (and was) easily forgotten.

This patch fixes the segmentation fault discovered in `_accumpart()` due to incorrect usage of `_cpyif()` by adding an offset parameter to `_cpyif()` so that the intent of setting `buf` to `NULL` can be cleanly transmitted to the test in `_cpyif()`. It was decided that this is less brittle than simply testing `buf` in one case because the offset parameter cannot be forgotten without causing a compile error, whereas the test can be (and was) easily forgotten.
croil merged commit 88308507dd into main1_1_0 2026年04月08日 14:29:17 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Resolved
Marks the issue as resolved.
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
croil/crpath!11
Reference in a new issue
croil/crpath
No description provided.
Delete branch "fix10"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?