comaps/url-processor
21
4
Fork
You've already forked url-processor
1

Rebrand the repository #15

Merged
pastk merged 3 commits from rebrand into master 2025年05月26日 17:54:58 +02:00
Contributor
Copy link

This PR rebrand the repository and doing first changes to support url processor in our infrastructure:

  • Move workflow to forgejo directory and bump dependencies
  • Move list of contributors in notice file
  • Remove in the readme part about cloudflare and remove dev urls and http urls
  • Replace in everywhere Organic Maps with CoMaps and omaps with comaps
  • Update url to repositories, socials networks and website (I have keep all intent to support OM:// scheme=)
  • Update tag meta with description from description website

I have few questions:

  • Do you want keep License MIT?
  • Do you host bookmarks test files on the CDN or do you need to reimport files on this repo?
  • Do you need to keep public/apple-app-site-association.json and public/assetlinks.json or need to be regenerate?

Fixes #13

Signed-off-by: jeanbaptisteC jeanbaptiste.charron@outlook.fr

This PR rebrand the repository and doing first changes to support url processor in our infrastructure: - Move workflow to forgejo directory and bump dependencies - Move list of contributors in notice file - Remove in the readme part about cloudflare and remove dev urls and http urls - Replace in everywhere Organic Maps with CoMaps and omaps with comaps - Update url to repositories, socials networks and website (I have keep all intent to support OM:// scheme=) - Update tag meta with description from description website I have few questions: - Do you want keep License MIT? - Do you host bookmarks test files on the CDN or do you need to reimport files on this repo? - Do you need to keep `public/apple-app-site-association.json` and `public/assetlinks.json` or need to be regenerate? Fixes #13 Signed-off-by: jeanbaptisteC <jeanbaptiste.charron@outlook.fr>
pastk left a comment
Copy link

Looks good overall!

Please try to decompose into several commits, e.g. licensing, docs, api...

Looks good overall! Please try to decompose into several commits, e.g. licensing, docs, api...
LICENSE Outdated
@ -1,5 +1,3 @@
Copyright 2022 Alexander Borsuk <me@alex.bio>
Owner
Copy link

Its a standard to have copyrights inside the license text for MIT.
Please put license changes into a separate commit

Its a standard to have copyrights inside the license text for MIT. Please put license changes into a separate commit
jeanbaptisteC marked this conversation as resolved
@ -17,3 +17,3 @@
"target": {
"namespace": "android_app",
"package_name": "app.organicmaps.beta",
"package_name": "app.comaps.beta",
Owner
Copy link

app.comaps.test

app.comaps.test
jeanbaptisteC marked this conversation as resolved
public/get.html Outdated
@ -9,16 +9,16 @@
<meta name="apple-itunes-app" content="app-id=1567437057">
Owner
Copy link

comment for now?

comment for now?
jeanbaptisteC marked this conversation as resolved
public/test.html Outdated
@ -49,12 +49,12 @@
<li><a href="om://o4B4pYZsRs">om://o4B4pYZsRs</a></li>
Owner
Copy link

please change to cm://

please change to `cm://`
jeanbaptisteC marked this conversation as resolved
public/test.html Outdated
@ -63,8 +63,8 @@
<li><a href="om://map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776">
Owner
Copy link

change all om:// to cm://

change all `om://` to `cm://`
jeanbaptisteC marked this conversation as resolved
wrangler.toml Outdated
@ -1,8 +1,6 @@
# Default worker is for dev only.
# See omaps and organicmaps environments below for production.
# See comaps environments below for production.
Owner
Copy link

This whole file might be CloudFlare specific. But let's see later.

This whole file might be CloudFlare specific. But let's see later.
jeanbaptisteC marked this conversation as resolved
Owner
Copy link

@jeanbaptisteC wrote in #15 (comment):

  • Do you host bookmarks test files on the CDN or do you need to reimport files on this repo?

These files are for users and 3party devs so it makes sense to have them on CDN.
However it'd be good to have a copy of them in the repo, so that they're never lost (I hope they're not too big?)

  • Do you need to keep public/apple-app-site-association.json and public/assetlinks.json or need to be regenerate?

No idea here :)

@jeanbaptisteC wrote in https://codeberg.org/comaps/url-processor/pulls/15#issue-1640103: > * Do you host bookmarks test files on the CDN or do you need to reimport files on this repo? These files are for users and 3party devs so it makes sense to have them on CDN. However it'd be good to have a copy of them in the repo, so that they're never lost (I hope they're not too big?) > * Do you need to keep `public/apple-app-site-association.json` and `public/assetlinks.json` or need to be regenerate? No idea here :)
Author
Contributor
Copy link

Fixes all comments and re-add bookmarks test files

Fixes all comments and re-add bookmarks test files
pastk left a comment
Copy link

Thanks!

Thanks!
pastk deleted branch rebrand 2025年05月26日 17:55:00 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
comaps/url-processor!15
Reference in a new issue
comaps/url-processor
No description provided.
Delete branch "rebrand"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?