comaps/subways
17
7
Fork
You've already forked subways
6

Add Brussels RER-GEN #74

Closed
jeanbaptisteC wants to merge 1 commit from jb_br into master
pull from: jb_br
merge into: comaps:master
comaps:master
comaps:jb_test
comaps:jb_lt
comaps:jb_tram
comaps:pastk-TEST-pr-62
comaps:pastk-TEST-pr-61
comaps:pastk-TEST-pr-54
comaps:pastk-TEST-pr-39
comaps:pastk-TEST-pr-41-and-39
comaps:pastk-TEST-pr-48
comaps:pastk-TEST-pr-41
comaps:pastk-TEST-pr-43
comaps:upstream
comaps:fixes-from-alexey2
comaps:fixes
Contributor
Copy link

This PR add brussels RER-GEN train, I have updated bbox with bbox finder
Frequency is one or two train(s) per hour

Signed-off-by: Jean-Baptiste jeanbaptiste.charron@outlook.fr

This PR add brussels RER-GEN train, I have updated bbox with [bbox finder](https://bboxfinder.com/#50.391886,3.746338,51.227528,5.114136) Frequency is one or two train(s) per hour Signed-off-by: Jean-Baptiste <jeanbaptiste.charron@outlook.fr>
Signed-off-by: Jean-Baptiste <jeanbaptiste.charron@outlook.fr>
Bovi887 left a comment
Copy link

Looks good to me. My only concern is if the frequency isn't too low to be justified to be added. Maybe good to get some more opinions on this.

Looks good to me. My only concern is if the frequency isn't too low to be justified to be added. Maybe good to get some more opinions on this.
Author
Contributor
Copy link

After doing some clean in commuter trains file, I agree two trains per hour is not enough
WDYT to integrate trains that offers only 3 or more trains per hour?

After doing some clean in commuter trains file, I agree two trains per hour is not enough WDYT to integrate trains that offers only 3 or more trains per hour?
Member
Copy link

I think that is a good minimum. Otherwise I could propose to add the full train network of the Netherlands 😅

I think that is a good minimum. Otherwise I could propose to add the full train network of the Netherlands 😅
Author
Contributor
Copy link

With recent discussions about commuter trains, this network could be re-consider?

With recent discussions about commuter trains, this network could be re-consider?
Member
Copy link

I don't think we should move it over to rapid unless service improves to at least ×ばつper hour. I considder the commuter file to be a list of networks that are just not frequent enough, but might get in the future, so we don't have to recollect networks (line number, bbox) if service improves.

Maybe we could considder to process all commuter lines in the future and render them in a way that people understand the difference between rapid and commuter lines (with a thinner line, for example). Might be better to just work on GTFS support instead though.

I don't think we should move it over to rapid unless service improves to at least ×ばつper hour. I considder the commuter file to be a list of networks that are just not frequent enough, but might get in the future, so we don't have to recollect networks (line number, bbox) if service improves. Maybe we could considder to process all commuter lines in the future and render them in a way that people understand the difference between rapid and commuter lines (with a thinner line, for example). Might be better to just work on GTFS support instead though.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
comaps/subways!74
Reference in a new issue
comaps/subways
No description provided.
Delete branch "jb_br"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?