WIP: Fix support of tram #70

Should we use the existing queries for rapid transit or should we create seperate queries only querying tram related items for overground processing? At least for QRELATIONS I don't think subway route relations are needed, while for the rapid file tram routes are not needed.

I have no real experience with this part of the code, so not sure what would be best.

This script doesn't know if we have selected rapid or overground mode but I guess it's better to extract data from osmium only once time

Okay, makes sense.

At line 260, however, we don't set the overground flag for process_subways.py, so it will only process in rapid mode.

As far as I can see this sh script needs to be run once for every file right now, so maybe it is easiest to add an overground flag there that we can pass through to the process_subways.py script. In that case we could also ajust the queries to the mode.

Alternatively we could try to change the script to process multiple input files with multiple modes at once, just a little more complicated I think.

I don't know how to proceeed to integrate to the actual workflow:

• Run overground process each time we generate subway after execute the rapid part
• Run only when we want with a parameter on the codeberg workflow, to wait we integrate more tram and fix issues before integrate first networks in the app.

Also, I don't know if it's better to merge this part now and merge CI in a seperate PR?

I don't know either, so i'll leave commenting on that for the CI people here.

To build website validator, I guess we need to execute both process in the same pipeline if we don't want to overwrite website validator for rapid with overground validator

If we have two seperate input files, wouldn't it make more sense to also have two output files and html validation files to keep it simple? Or do you think it is better to have it all in one place? I would like to preserve the format and the statistics of the current html subways page if possible to keep side by side comparison with VK easy.

Actual UI support rapid and overground transport on the same page with new columns for trams and bus

Right now it is set up to show either rapid or overground lines by setting the boolean overground variable as far as I can see, not both. We could of course change this. I just like the idea of keeping rapid and overground/tram a bit seperate, also with potential different rendering in mind (one input -> one output). A seperate validation html feels most logical to me, as it would be following this pattern.

Feel free to update this PR, If you know how to improve html generator part

Can be combined in one if by using

if el["tags"].get("railway") in ["stop", "tram_stop"]:

I also made this change in my partial tram PR, so depending on which PR gets merged first it can be removed from the other to prevent merge conflicts.

Sorry, wrong brackets (i'm used to PHP arrays). Should be

if el["tags"].get("railway") in ("stop", "tram_stop"):

Fixed

Indentation of the if section looks wrong here. I think it should go outside of the with ... as f:, so one level back while the strings inside of the tuple should be indented.

The whole thing could even be inlined:

reader = csv.DictReader(
 data.splitlines(),
 fieldnames=(
 "id",
 "name",
 "country",
 "continent",
 "num_lines",
 "num_light_lines",
 "bbox",
 "networks",
 ) if not overground else (
 "id",
 "name",
 "country",
 "continent",
 "num_tram_lines",
 "num_trolleybus_lines",
 "num_bus_lines",
 "num_other_lines",
 "bbox",
 "networks",
 ),
)

Fixed

One closing bracket too many (last one should be removed) 😉