comaps/subways
17
7
Fork
You've already forked subways
6

Add new light_rail networks in France #66

Closed
jeanbaptisteC wants to merge 1 commit from jb_fr_network into master
pull from: jb_fr_network
merge into: comaps:master
comaps:master
comaps:jb_test
comaps:jb_lt
comaps:jb_tram
comaps:pastk-TEST-pr-62
comaps:pastk-TEST-pr-61
comaps:pastk-TEST-pr-54
comaps:pastk-TEST-pr-39
comaps:pastk-TEST-pr-41-and-39
comaps:pastk-TEST-pr-48
comaps:pastk-TEST-pr-41
comaps:pastk-TEST-pr-43
comaps:upstream
comaps:fixes-from-alexey2
comaps:fixes
Contributor
Copy link

Fixes #65

I have used overpass to get bbox

Signed-off-by: Jean-Baptiste jeanbaptiste.charron@outlook.fr

Fixes #65 I have used overpass to get bbox Signed-off-by: Jean-Baptiste <jeanbaptiste.charron@outlook.fr>
Signed-off-by: Jean-Baptiste <jeanbaptiste.charron@outlook.fr>
Bovi887 left a comment
Copy link

Bounding boxes are LGTM.

I would avoid unnecessary "light_rail:". The default behaviour is to only look for route=light_rail and route=subway, so as long as there are no conflicting/unwanted subways it can be omitted so any future subway routes would also be picked up.

Unfortunately most networks use partial tram tagging, making them fail right now. More info in the individual comments, where I also left the html results of my test runs.

Bounding boxes are LGTM. I would avoid unnecessary "light_rail:". The default behaviour is to only look for route=light_rail and route=subway, so as long as there are no conflicting/unwanted subways it can be omitted so any future subway routes would also be picked up. Unfortunately most networks use partial tram tagging, making them fail right now. More info in the individual comments, where I also left the html results of my test runs.
@ -253,3 +253,3 @@
406,Tampere,Finland,Europe,0,2,"23.675,61.435524,23.880333,61.53",light_rail:Nysse,,,https://en.wikipedia.org/wiki/Tampere_light_rail,
251,Lille,France,Europe,2,0,"2.892838,50.536126,3.307571,50.798991",,,,,
252,Lyon,France,Europe,4,0,"4.592972,45.54964,5.120316,45.918677",TCL,,,,
252,Lyon,France,Europe,4,4,"4.592972,45.54964,5.120316,45.918677","TCL,light_rail:",,,,
Member
Copy link

Many of these light rail lines use PTV1, i'm not sure how well that is supported by the generator.

The Rhônexpress uses partial tram tagging, so can not be supported right now. To exclude it the other lines should be specified by network.

Also, the network name 'TCL' and type 'light_rail' are mixed here. Types should be before the colon, network names after. I've tested this one by just completely removing the specified network.

Many of these light rail lines use PTV1, i'm not sure how well that is supported by the generator. The Rhônexpress uses partial tram tagging, so can not be supported right now. To exclude it the other lines should be specified by network. Also, the network name 'TCL' and type 'light_rail' are mixed here. Types should be before the colon, network names after. I've tested this one by just completely removing the specified network.
Author
Contributor
Copy link

I have asked to the french community for Rhônexpress because it's an important transport in Lyon to go to the airport

I have asked to the french community for Rhônexpress because it's an important transport in Lyon to go to the airport
@ -258,3 +258,4 @@
255,Paris RER,France,Europe,0,5,"1.8649,48.2256,2.9031,49.3153",train:RER,,,,
256,Rennes,France,Europe,2,0,"-1.747169,48.065691,-1.576881,48.161505",subway:,,,,
257,Toulouse,France,Europe,2,1,"1.213303,43.440955,1.581345,43.712557","train,subway:fr_tisseo;Tisséo",,,,
441,Nantes,France,Europe,0,2,"-1.5488284,47.0855987,-1.2864232,47.7171268","light_rail:",,,,
Member
Copy link

This network does have good potential to be added, as it is not tagged as tram and uses PTV2 tagging. The only issue right now is that some stations miss stop areas and station=light_rail or light_rail=yes.

This network does have good potential to be added, as it is not tagged as tram and uses PTV2 tagging. The only issue right now is that some stations miss stop areas and station=light_rail or light_rail=yes.
Author
Contributor
Copy link

this network is a tram/train seems to complicate to add for now

this network is a tram/train seems to complicate to add for now
jeanbaptisteC marked this conversation as resolved
@ -259,2 +259,4 @@
256,Rennes,France,Europe,2,0,"-1.747169,48.065691,-1.576881,48.161505",subway:,,,,
257,Toulouse,France,Europe,2,1,"1.213303,43.440955,1.581345,43.712557","train,subway:fr_tisseo;Tisséo",,,,
441,Nantes,France,Europe,0,2,"-1.5488284,47.0855987,-1.2864232,47.7171268","light_rail:",,,,
442,Mulhouse,France,Europe,0,1,"7.0878188,47.7403354,7.3435697,47.8144605","light_rail:",,,,
Member
Copy link

Unfortunately partially tagged as tram. I'll might try looking into adding support for those route=light_rail lines with partial tram tagging as a first step of tram support, but for now it's failing.

Unfortunately partially tagged as tram. I'll might try looking into adding support for those route=light_rail lines with partial tram tagging as a first step of tram support, but for now it's failing.
@ -280,6 +282,7 @@ Horner Rennbahn station is closed until April 2024. 5 stations of U4 are missing
407,Rostock,Germany,Europe,0,3,"12.054899,53.791936,12.358232,54.178244",train:s-bahn,,,,
414,Stuttgart,Germany,Europe,0,16,"9.0386,48.685693,9.311829,48.884711",light_rail:Verkehrs- und Tarifverbund Stuttgart,,,,
272,Stuttgart S-Bahn,Germany,Europe,0,9,"8.860058,48.590796,9.527992,48.949577",train:s-bahn,,,,
443,Saarbrucken,Germany,Europe,0,2,"6.8911422,49.1065846,7.0689803,49.4084704",light_rail:,,,,
Member
Copy link

Same problem with partial tram tagging.

Same problem with partial tram tagging.
Author
Contributor
Copy link

Thanks for your feedback, I understood better why these light_rail was never added in the past
Let's re-integrate it when we support tram transport

Thanks for your feedback, I understood better why these light_rail was never added in the past Let's re-integrate it when we support tram transport
Member
Copy link

@jeanbaptisteC I've managed to get the two Nantes lines working with minor tagging improvements, so we could add those if you want to.

One more little thing: the list of cities is sorted alphabetically. So if you add Nantes, could you please put it below Marseille in the csv?

@jeanbaptisteC I've managed to get the two Nantes lines working with minor tagging improvements, so we could add those if you want to. One more little thing: the list of cities is sorted alphabetically. So if you add Nantes, could you please put it below Marseille in the csv?
Author
Contributor
Copy link

Added here #67 because rebasing doesn't work in this PR

Added here #67 because rebasing doesn't work in this PR

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
comaps/subways!66
Reference in a new issue
comaps/subways
No description provided.
Delete branch "jb_fr_network"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?