Remove station count from validator and data sheet #62

Bovi887 commented 2026年04月10日 16:48:41 +02:00

In #55 it was discussed if it was nescessary to keep the station count for validation purposes or if it could be removed, because it is a lot of work to maintain. I think that, if we keep the line count validation for validation purposes (to detect network changes for example), we can drop the station count validation.

This PR removes the station count from the data sheet and removes all validation of the station count against the data sheet. The number of found stations is still in the output, just like we did with the interchanges.

Question: Is there anyone who thinks we should keep the station count?

Signed-off-by: Bovi887 bovi887@noreply.codeberg.org

In #55 it was discussed if it was nescessary to keep the station count for validation purposes or if it could be removed, because it is a lot of work to maintain. I think that, if we keep the line count validation for validation purposes (to detect network changes for example), we can drop the station count validation. This PR removes the station count from the data sheet and removes all validation of the station count against the data sheet. The number of found stations is still in the output, just like we did with the interchanges. Question: Is there anyone who thinks we should keep the station count? Signed-off-by: Bovi887 <bovi887@noreply.codeberg.org>

Bovi887 commented 2026年04月14日 16:42:33 +02:00

I've just changed the validator to throw an error if there are less than 2 stations in a city. A network with 1 or 0 stations isn't usable and should fail so when backup cities are saved a backup can be used.

I think that makes the PR is ready for review.

I've just changed the validator to throw an error if there are less than 2 stations in a city. A network with 1 or 0 stations isn't usable and should fail so when backup cities are saved a backup can be used. I think that makes the PR is ready for review.

pastk commented 2026年04月20日 07:41:58 +02:00

I did a test run and it looks good!
https://codeberg.org/comaps/comaps/actions/runs/16931/jobs/1/attempt/1
https://mapgen-fi-1.comaps.app/subway/validator/index.html

I did a test run and it looks good! https://codeberg.org/comaps/comaps/actions/runs/16931/jobs/1/attempt/1 https://mapgen-fi-1.comaps.app/subway/validator/index.html