comaps/subways
17
7
Fork
You've already forked subways
6

Merge Philadelphia networks #60

Merged
pastk merged 1 commit from Bovi887/subways:merge-philadelphia-networks into master 2026年04月04日 23:21:13 +02:00
Member
Copy link

Merges all networks of Philadelphia into one, so the networks can be omitted (less specified networks = less maintaining).

The SNJRG network is currently failing on VK because off the line not being found by network. This change should keep this line from disappearing in our version.

Signed-off-by: Bovi887 bovi887@noreply.codeberg.org

Merges all networks of Philadelphia into one, so the networks can be omitted (less specified networks = less maintaining). The SNJRG network is currently failing on VK because off the line not being found by network. This change should keep this line from disappearing in our version. Signed-off-by: Bovi887 <bovi887@noreply.codeberg.org>
Signed-off-by: Bovi887 <bovi887@noreply.codeberg.org>
pastk left a comment
Copy link

Thanks!

Thanks!
Bovi887 deleted branch merge-philadelphia-networks 2026年04月05日 00:08:28 +02:00
Owner
Copy link

Probably it makes sense to distinguish networks only if they're not integrated and we're going to distinguish them on the map (via a different icon and/or title, e.g. see London)?

Probably it makes sense to distinguish networks only if they're not integrated and we're going to distinguish them on the map (via a different icon and/or title, e.g. see London)?
Author
Member
Copy link

Yeah, Philadelphia has a SEPTA icon shown on subway stations, but this is also shown on the PATCO line (also before this change). 😉 I think the current implementation of these custom icons doesn't check for networks. If we at some point do want to check for networks I think it would make sense do that based on the OSM network tag on the stations and not based on the subway generator. London isn't split in diffrent 'cities' (networks) eather.

Yeah, Philadelphia has a SEPTA icon shown on subway stations, but this is also shown on the PATCO line (also before this change). 😉 I think the current implementation of these custom icons doesn't check for networks. If we at some point do want to check for networks I think it would make sense do that based on the OSM network tag on the stations and not based on the subway generator. London isn't split in diffrent 'cities' (networks) eather.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
comaps/subways!60
Reference in a new issue
comaps/subways
No description provided.
Delete branch "Bovi887/subways:merge-philadelphia-networks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?