Fixed Stremio #43

C10udburst (Migrated from github.com) commented 2023年03月16日 07:03:05 +01:00

shouldn't this line be removed?

shouldn't this line be removed?

pokerface-bad (Migrated from github.com) commented 2023年03月16日 08:30:42 +01:00

can you check new commit, i made some improvement so that catalog addons like tmdb support streaming.
about that url is json and i need id to check if that imdb or not (in new commit)

btw @C10udburst do you know all route stremio have ? like /catalog, /meta and /stream
somehow /meta route doesn't work in some catalog add ons like Trakt and Cyberflix

can you check new commit, i made some improvement so that catalog addons like tmdb support streaming. about that url is json and i need id to check if that imdb or not (in new commit) btw @C10udburst do you know all route stremio have ? like /catalog, /meta and /stream somehow /meta route doesn't work in some catalog add ons like Trakt and Cyberflix

Blatzar (Migrated from github.com) commented 2023年03月16日 14:24:52 +01:00

This shouldn't be hardcoded imo.
The extension relies on cloning, but this will override any custom stuff.

This shouldn't be hardcoded imo. The extension relies on cloning, but this will override any custom stuff.

pokerface-bad (Migrated from github.com) commented 2023年03月17日 02:46:12 +01:00

clone only replace mainUrl. it just some addons relies with other addons like torrentio that only provide /stream route so it only work inside catalog addons. i add this so that we can stream from catalog addons like tmdb.
it won't f up stream addons like iptv addons because i make a check first in code :

isMetaId = isImdborTmdb(res.id)

also in dataUrl in loadResponse

if(isMetaId) "${provider.streamUrl}/stream/${type}/${id}.json" else "${provider.mainUrl}/stream/${type}/${id}.json"

i can remove it but catalog addons just being a catalog like now
the better approach is to add setting layout so user can add source addons by themself (torrentio.. etc), but i need more time to learn that and this is as far as i can do for now 😄
detail => stremio-addon-sdk

clone only replace mainUrl. it just some addons relies with other addons like torrentio that only provide /stream route so it only work inside catalog addons. i add this so that we can stream from catalog addons like [tmdb](https://stremio-tmdb-addon.vercel.app/). it won't f up stream addons like iptv addons because i make a check first in code : ```kt isMetaId = isImdborTmdb(res.id) ``` also in dataUrl in loadResponse ```kt if(isMetaId) "${provider.streamUrl}/stream/${type}/${id}.json" else "${provider.mainUrl}/stream/${type}/${id}.json" ``` i can remove it but catalog addons just being a catalog like now the better approach is to add setting layout so user can add source addons by themself (torrentio.. etc), but i need more time to learn that and this is as far as i can do for now 😄 detail => [stremio-addon-sdk](https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/README.md)