4
9
Fork
You've already forked libchewing
3

build: remove unused swift plugin file and update error message #793

Merged
kanru merged 2 commits from push-lvzutovlsnnl into master 2025年12月30日 16:20:54 +01:00
kanru commented 2025年12月30日 16:00:26 +01:00 (Migrated from github.com)
Copy link
See also https://github.com/chewing/libchewing/pull/790#issuecomment-3698969004 Thanks to @ShikiSuen
ShikiSuen (Migrated from github.com) approved these changes 2025年12月30日 16:03:33 +01:00
codecov[bot] commented 2025年12月30日 16:04:41 +01:00 (Migrated from github.com)
Copy link

Codecov Report

All modified and coverable lines are covered by tests.
Project coverage is 92.06%. Comparing base (999ee00) to head (036d4c3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
 Coverage 92.06% 92.06% 
=======================================
 Files 37 37 
 Lines 9253 9253 
=======================================
 Hits 8519 8519 
 Misses 734 734 

View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
## [Codecov](https://app.codecov.io/gh/chewing/libchewing/pull/793?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.06%. Comparing base ([`999ee00`](https://app.codecov.io/gh/chewing/libchewing/commit/999ee00e8f6e709cb3fea8909e2b3d55be87add7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing)) to head ([`036d4c3`](https://app.codecov.io/gh/chewing/libchewing/commit/036d4c335ac56fca57a07f9da25a8c4387cba298?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing)). :warning: Report is 2 commits behind head on master. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #793 +/- ## ======================================= Coverage 92.06% 92.06% ======================================= Files 37 37 Lines 9253 9253 ======================================= Hits 8519 8519 Misses 734 734 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/chewing/libchewing/pull/793?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
ShikiSuen (Migrated from github.com) requested changes 2025年12月30日 16:07:54 +01:00
ShikiSuen (Migrated from github.com) left a comment
Copy link

I think we need to add this Provide libchewing as a Swift package with the exposures of C_based APIs only. instead. This ensures that no one expects Swiftified APIs from this package (which brings extra burden to this repo). If anyone wants Swiftified APIs, he / she can make them by himself / herself.

I think we need to add this `Provide libchewing as a Swift package with the exposures of C_based APIs only.` instead. This ensures that no one expects Swiftified APIs from this package (which brings extra burden to this repo). If anyone wants Swiftified APIs, he / she can make them by himself / herself.
@ -16,6 +16,7 @@ What's New in libchewing (unreleased)
- New boolean config option `chewing.sort_candidates_by_frequency` can be
ShikiSuen (Migrated from github.com) commented 2025年12月30日 16:06:46 +01:00
Copy link
  • Provide libchewing as a Swift package with the exposures of C_based APIs only.
- Provide libchewing as a Swift package with the exposures of C_based APIs only.
kanru (Migrated from github.com) reviewed 2025年12月30日 16:12:35 +01:00
@ -16,6 +16,7 @@ What's New in libchewing (unreleased)
- New boolean config option `chewing.sort_candidates_by_frequency` can be
kanru (Migrated from github.com) commented 2025年12月30日 16:12:35 +01:00
Copy link

Make sense. For me libchewing refers only to the C API but your edit makes it more clear for people unfamiliar with the history of libchewing.

Make sense. For me `libchewing` refers only to the C API but your edit makes it more clear for people unfamiliar with the history of libchewing.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
dictionary
duplicate
fixed
0.11.0

Archived

fixed
0.13.0
refactoring

Archived

rewrite in rust
Might be fixed by the rust rewrite
thirdparty
arch
aarch64
系統架構是 Aarch64
arch
x86_64
系統架構是 x86_64
cannot reproduce
無法重現問題 Cannot reproduce the issue
contribution welcome
歡迎來幫忙 Contributions are very welcome, get started here
duplicate
重複的問題回報 This issue or pull request already exists
good first issue
適合新手 Interested in contributing? Get started here.
help wanted
需要高手相助 Need some help
invalid
回報的問題無效 Something is wrong
kind
bug
有東西不正常運作 Something is not working
kind
doc
加強文件說明 Enhance documentation
kind
enhancement
新功能 New feature
kind
mega issue
同一個問題回報中包含多個問題 Multiple issues reported
kind
question
只是問問題 Asking a question
needinfo
需要更多資訊 More information is needed
os
apple
作業系統是 MacOS 或 iOS
os
linux
作業系統是 GNU Linux
os
windows
作業系統是 Windows
to be determined
還未被說服有需求 Can't decide whether this is needed
upstream
跟上游軟體相關 Related to an upstream repository, already reported there
wontfix
我們決定不處理 Won't be fixed
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
chewing/libchewing!793
Reference in a new issue
chewing/libchewing
No description provided.
Delete branch "push-lvzutovlsnnl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?