chore: skip chewing_testhelper if not BUILD_TESTING #761

eagleoflqj commented 2025年11月09日 17:00:18 +01:00 (Migrated from github.com)

Given github.com/chewing/libchewing@69ae0e454a/CMakeLists.txt (L167-L169) it's better not build testhelper when tests are disabled.

Given https://github.com/chewing/libchewing/blob/69ae0e454a34c9ac193fc648a7215f06b5e9c52a/CMakeLists.txt#L167-L169 it's better not build testhelper when tests are disabled.

codecov[bot] commented 2025年11月09日 17:02:07 +01:00 (Migrated from github.com)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (69ae0e4) to head (af97fc7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@
## master #761 +/- ##
=======================================
 Coverage 91.90% 91.90% 
=======================================
 Files 37 37 
 Lines 8815 8815 
=======================================
 Hits 8101 8101 
 Misses 714 714 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

## [Codecov](https://app.codecov.io/gh/chewing/libchewing/pull/761?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 91.90%. Comparing base ([`69ae0e4`](https://app.codecov.io/gh/chewing/libchewing/commit/69ae0e454a34c9ac193fc648a7215f06b5e9c52a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing)) to head ([`af97fc7`](https://app.codecov.io/gh/chewing/libchewing/commit/af97fc7dda0aa87a7da9b80ae55e9ce093d43a2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing)). :warning: Report is 1 commits behind head on master. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #761 +/- ## ======================================= Coverage 91.90% 91.90% ======================================= Files 37 37 Lines 8815 8815 ======================================= Hits 8101 8101 Misses 714 714 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/chewing/libchewing/pull/761?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=chewing). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>

kanru commented 2025年11月09日 23:51:08 +01:00 (Migrated from github.com)

Thanks!

Thanks!