fix!: support redaction of rotated, cropped and scaled pages, adjust intersection definition #182

mahlzahn commented 2026年04月02日 18:33:42 +02:00

1. Unfortunately, upstream library PyMuPDF is quite buggy for rotated or scaled pages. Thus, I
   • reimplemented the determination of rotation or derotation matrix from pages that can be used with scaled pages
   • feed rotated redaction rectangles (with page’s derotation matrix to PyMuPDF’s redaction annotations
   • reimplemented the drawing of the final redaction rectangles
2. Further, instead of removing links, widgets and annotations if they intersect with redaction rectangles, they will be now removed if they "overlap", means not only touching with their borders. Also, tests for overlapping with points and lines have been added.
3. Additionally, the safer sanitization function was simplified. Because also PyMuPDF’s function Document.insert_pdf was not reliably copying I reimplemented
   • copying of links to have proper location on rotated/scaled pages
   • copying of widgets, which were sometimes silently lost for I don’t know which reason

Closes #161

1. Unfortunately, upstream library PyMuPDF is quite buggy for rotated or scaled pages. Thus, I - reimplemented the determination of rotation or derotation matrix from pages that can be used with scaled pages - feed rotated redaction rectangles (with page’s derotation matrix to PyMuPDF’s redaction annotations - reimplemented the drawing of the final redaction rectangles 2. Further, instead of removing links, widgets and annotations if they intersect with redaction rectangles, they will be now removed if they "overlap", means not only touching with their borders. Also, tests for overlapping with points and lines have been added. 3. Additionally, the safer sanitization function was simplified. Because also PyMuPDF’s function `Document.insert_pdf` was not reliably copying I reimplemented - copying of links to have proper location on rotated/scaled pages - copying of widgets, which were sometimes silently lost for I don’t know which reason Closes #161

censor-bot commented 2026年04月02日 18:34:36 +02:00

Note

The build job for 69cedfb037abc0c7095ec662884f133d94418b58 finished with status success. Install and run the x86_64 test build with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6371729/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel

> **Note** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6371729) for 69cedfb037abc0c7095ec662884f133d94418b58 finished with status **success**. Install and run the x86_64 test build with: > > curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6371729/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak > flatpak install --user censor-dev.flatpak > flatpak run --user page.codeberg.censor.Censor.Devel

Reason:

censor-bot commented 2026年04月03日 11:27:04 +02:00

Note

The build job for ed8c828a62 finished with status success. Install and run the x86_64 test build with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6374611/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel

> **Note** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6374611) for ed8c828a62bd45fa9c46e419849701d868a95dd1 finished with status **success**. Install and run the x86_64 test build with: > > curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6374611/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak > flatpak install --user censor-dev.flatpak > flatpak run --user page.codeberg.censor.Censor.Devel