censor/Censor
1
37
Fork
You've already forked Censor
3

feat: check successful redaction and warn user if needed #159

Merged
mahlzahn merged 3 commits from mahlzahn/feat_check_redactions_after into main 2026年03月23日 10:42:49 +01:00 AGit

Related: #144

Related: #144
censor-bot approved these changes 2026年03月19日 18:50:29 +01:00
Dismissed
mahlzahn added this to the v0.6.0 milestone 2026年03月19日 18:52:09 +01:00
@ -221,0 +250,4 @@
'samples_ghostpdl/zlib/doc/crc-doc.1.0.pdf',
],
# Failing correct redaction because of weird page boxes or rotation
'failing redaction with wrong coordinates (#???)': [
Author
Owner
Copy link

#161

#161
mahlzahn marked this conversation as resolved
@ -221,0 +271,4 @@
],
# Failing widgets redaction
# TODO
'failing widgets redaction (#???)': [
Author
Owner
Copy link

#162

#162
mahlzahn marked this conversation as resolved
@ -221,0 +276,4 @@
],
# Failing for unknown reason
# TODO
'failing saving for unknown reason (#???)': [
Author
Owner
Copy link

#163

#163
mahlzahn marked this conversation as resolved
@ -208,6 +213,14 @@ class Document:
remove_xml_metadata=True)
except SanitizationWarning as warning:
warnings.append(str(warning))
# Check redactions to warn user if some redactions were not applied
Author
Owner
Copy link

Move redaction checking after document saving? In case this fails for another error it shouldn't block saving.

Move redaction checking after document saving? In case this fails for another error it shouldn't block saving.
mahlzahn marked this conversation as resolved
mahlzahn dismissed censor-bot's review 2026年03月23日 10:39:17 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mahlzahn force-pushed mahlzahn/feat_check_redactions_after from 99d7576e1e
All checks were successful
/ build-start (pull_request_target) Successful in 14s
/ checks (pull_request) Successful in 1m13s
/ merge-conditions (pull_request) Successful in 7s
to bc20776d56
Some checks failed
/ merge-conditions (pull_request) Successful in 8s
/ build-start (pull_request_target) Successful in 12s
/ checks (pull_request) Has been cancelled
2026年03月23日 10:39:20 +01:00 Compare
i18n: add warning messages
All checks were successful
/ merge-conditions (pull_request) Successful in 9s
/ build-start (pull_request_target) Successful in 11s
/ checks (pull_request) Successful in 1m14s
/ release-publish (pull_request_target) Has been skipped
911ede8a24
censor-bot approved these changes 2026年03月23日 10:40:09 +01:00
Dismissed

Note

The build job for 911ede8a24 finished with status success. Install and run the x86_64 test build with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6330841/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel
> **Note** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6330841) for 911ede8a244f470f263c4a991195e584d79f0fd9 finished with status **success**. Install and run the x86_64 test build with: > > curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6330841/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak > flatpak install --user censor-dev.flatpak > flatpak run --user page.codeberg.censor.Censor.Devel
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
censor/Censor!159
Reference in a new issue
censor/Censor
No description provided.
Delete branch "mahlzahn/feat_check_redactions_after"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?