WIP: feat: redact vector graphics with less strict option #114

mahlzahn commented 2026年03月06日 13:01:01 +01:00

Edit: WIP for now, it should be optional, maybe in settings dialog or something else.

I implemented custom removal of graphics (vector drawings) using pypdf library when points are found within redaction rectangles.

This tries to remove drawings with any of the following properties from the page (on top of the redaction from PyMuPDF):

• the drawing is fully covered by a redaction
• any rectangle of the graphic is fully covered by a redaction
• any curve, line, or quadruple has a point covered by a redaction
• if the drawing has no item (curve, line, etc.) and intersects with a redaction

It by decision keeps a drawing even if its rectangle(s) have some intersection with redaction rectangles.

Only after this implementation, I understood that the original issue was that pymupdf.PDF_REDACT_LINE_ART_REMOVE_IF_TOUCHED was not applied because of a documentation issue. It is now applied if the custom removal fails.

Related: #5, !115

Edit: WIP for now, it should be optional, maybe in settings dialog or something else. I implemented custom removal of graphics (vector drawings) using pypdf library when points are found within redaction rectangles. This tries to remove drawings with any of the following properties from the page (on top of the redaction from PyMuPDF): - the drawing is fully covered by a redaction - any rectangle of the graphic is fully covered by a redaction - any curve, line, or quadruple has a point covered by a redaction - if the drawing has no item (curve, line, etc.) and intersects with a redaction It by decision keeps a drawing even if its rectangle(s) have some intersection with redaction rectangles. Only after this implementation, I understood that the original issue was that `pymupdf.PDF_REDACT_LINE_ART_REMOVE_IF_TOUCHED` was not applied because of a [documentation issue](https://github.com/pymupdf/PyMuPDF/issues/4924). It is now applied if the custom removal fails. Related: #5, !115

censor-bot commented 2026年03月06日 13:02:53 +01:00

Warning

The build job for 4742741a3fe477c349add6879ac3f048fd7fafb3 finished with status failed.

> **Warning** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6245449) for 4742741a3fe477c349add6879ac3f048fd7fafb3 finished with status **failed**.

censor-bot commented 2026年03月06日 15:24:15 +01:00

Note

The build job for 1f65f4fc2e finished with status success. Install and run the x86_64 test build with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6246303/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel

> **Note** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6246303) for 1f65f4fc2e3accdef3be5d078b9db9106ea62684 finished with status **success**. Install and run the x86_64 test build with: > > curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6246303/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak > flatpak install --user censor-dev.flatpak > flatpak run --user page.codeberg.censor.Censor.Devel

censor-bot commented 2026年07月13日 12:45:22 +02:00

Note

The build job for 1f65f4fc2e finished with status success. Install and run the x86_64 test build with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6756875/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel

> **Note** > The [build job](https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6756875) for 1f65f4fc2e3accdef3be5d078b9db9106ea62684 finished with status **success**. Install and run the x86_64 test build with: > > curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6756875/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak > flatpak install --user censor-dev.flatpak > flatpak run --user page.codeberg.censor.Censor.Devel

This pull request has changes conflicting with the target branch.