bug?: saving redacted files ,by overwriting the original,does not work #90

martin762green commented 2026年02月26日 21:00:58 +01:00

Assuming this is a different issue to the #78 previously raised.
I am getting consistent failure to "save As" a redacted pdf file by "save as" attempting to overwrite the original file name. I am seeing the error message
ValueError("save to original must be incremental")

Seen on Ubuntu 25.10 with both aarch64 and x86_64 hardware

cheers Martin

Assuming this is a different issue to the #78 previously raised. I am getting consistent failure to "save As" a redacted pdf file by "save as" attempting to overwrite the original file name. I am seeing the error message **ValueError("save to original must be incremental")** Seen on Ubuntu 25.10 with both aarch64 and x86_64 hardware cheers Martin

martin762green commented 2026年02月26日 21:04:00 +01:00

Should have added this behaviour is true for the stable down load from flathub (0.3) and the latest main repository

Should have added this behaviour is true for the stable down load from flathub (0.3) and the latest main repository

martin762green commented 2026年02月26日 21:25:21 +01:00

Having now looked at the pymupdf documents and the meaning of "incremental" in this context this may be by design rather than a bug. I wqill close when confirmed.
cheers

Having now looked at the pymupdf documents and the meaning of "incremental" in this context this may be by design rather than a bug. I wqill close when confirmed. cheers

mahlzahn commented 2026年02月27日 12:38:12 +01:00

Thanks for reporting this issue, and it is quite possible that it is same as #78, but I wasn’t able to replicate till now. And nice that you gave the important hint about the ValueError. Can you confirm that you tried saving a redacted document which includes signatures?

I could reproduce the issue, e.g., with the first test file from here: https://www.tecxoft.com/samples.php. That is unexpected and should be fixed within Censor.

Thanks for reporting this issue, and it is quite possible that it is same as #78, but I wasn’t able to replicate till now. And nice that you gave the important hint about the ValueError. Can you confirm that you tried saving a redacted document which includes signatures? I could reproduce the issue, e.g., with the first test file from here: https://www.tecxoft.com/samples.php. That is unexpected and should be fixed within Censor.

martin762green commented 2026年02月27日 13:39:18 +01:00

My original testing was on a scanned random document. Not sure what you meant by "signature" so I have done a quick check on the stable v0.3
1 added a freeform signature and re scanned as pdf.
2 Added an electronic signature as text
3 added an electronic signature as free-forrm drawing

In each case redacting the document I "saved as "successfully with a new file name.
Unsuccessful trying to overwrite the existing file name. Value error same as before.

Are you sure this is not down to pymupdf by design?
Cheers

My original testing was on a scanned random document. Not sure what you meant by "signature" so I have done a quick check on the stable v0.3 1 added a freeform signature and re scanned as pdf. 2 Added an electronic signature as text 3 added an electronic signature as free-forrm drawing In each case redacting the document I "saved as "successfully with a new file name. Unsuccessful trying to overwrite the existing file name. Value error same as before. Are you sure this is not down to pymupdf by design? Cheers

martin762green commented 2026年02月27日 13:47:32 +01:00

PS also used tecxoft snippet and same results
Cheers

PS also used tecxoft snippet and same results Cheers

mahlzahn commented 2026年02月27日 15:24:14 +01:00

@martin762green wrote in #90 (comment):

My original testing was on a scanned random document.

True, indeed it is independent of signature and happens to other documents, too.

@martin762green wrote in https://codeberg.org/censor/Censor/issues/90#issuecomment-11050373: > My original testing was on a scanned random document. True, indeed it is independent of signature and happens to other documents, too.

mahlzahn commented 2026年02月27日 15:28:34 +01:00

May I ask you to test the flatpak (x86_64) from #92, please? You can download and install it with:

curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6212525/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak
flatpak install --user censor-dev.flatpak
flatpak run --user page.codeberg.censor.Censor.Devel

May I ask you to test the flatpak (x86_64) from #92, please? You can download and install it with: ``` curl https://gitlab.gnome.org/mahlzahn/censor-ci/-/jobs/6212525/artifacts/raw/censor-dev.flatpak -o censor-dev.flatpak flatpak install --user censor-dev.flatpak flatpak run --user page.codeberg.censor.Censor.Devel ```

martin762green commented 2026年02月27日 20:34:12 +01:00

@mahlzahn: As requested above. Job done! see #92

@mahlzahn: As requested above. Job done! see #92

censor/Censor