fix: allow repeated saving to same file path #92

mahlzahn commented 2026年02月27日 15:23:49 +01:00

Saving repeatedly to the same file path overwriting an existing file
failed due to PyMuPDF raising a ValueError

Traceback (most recent call last):
 File "/app/share/censor/censor/window.py", line 237, in on_save_response
 self.save_file(file)
 ~~~~~~~~~~~~~~^^^^^^
 File "/app/share/censor/censor/window.py", line 241, in save_file
 self.document.save(file.get_path())
 ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
 File "/app/share/censor/censor/document.py", line 123, in save
 mupdf_document.save(path)
 ~~~~~~~~~~~~~~~~~~~^^^^^^
 File "/app/lib/python3.13/site-packages/pymupdf/__init__.py", line 6511, in save
 raise ValueError("save to original must be incremental")
ValueError: save to original must be incremental

Closes: #78
Closes #90

Saving repeatedly to the same file path overwriting an existing file failed due to PyMuPDF raising a ValueError ``` Traceback (most recent call last): File "/app/share/censor/censor/window.py", line 237, in on_save_response self.save_file(file) ~~~~~~~~~~~~~~^^^^^^ File "/app/share/censor/censor/window.py", line 241, in save_file self.document.save(file.get_path()) ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^ File "/app/share/censor/censor/document.py", line 123, in save mupdf_document.save(path) ~~~~~~~~~~~~~~~~~~~^^^^^^ File "/app/lib/python3.13/site-packages/pymupdf/__init__.py", line 6511, in save raise ValueError("save to original must be incremental") ValueError: save to original must be incremental ``` Closes: #78 Closes #90

martin762green commented 2026年02月27日 20:32:20 +01:00

@mahlzahn: downloaded as instructed on x86_64. Perfect!
Errors gone.

@mahlzahn: downloaded as instructed on x86_64. Perfect! Errors gone.

mahlzahn commented 2026年02月27日 20:37:52 +01:00

@martin762green wrote in #92 (comment):

@mahlzahn: downloaded as instructed on x86_64. Perfect! Errors gone.

Thanks for testing!

@martin762green wrote in https://codeberg.org/censor/Censor/pulls/92#issuecomment-11061449: > @mahlzahn: downloaded as instructed on x86_64. Perfect! Errors gone. Thanks for testing!