celenity/Phoenix
8
198
Fork
You've already forked Phoenix
19

refactor: remove obsolete files, update scripts #286

Merged
celenity merged 1 commit from koru/Phoenix:obsolete into dev 2026年05月13日 21:59:59 +02:00
Contributor
Copy link

Attempt to reduce the number of files in the repository. I also considered moving the macOS install/uninstall scripts to /scripts, but ultimately decided against it.

  • Removed unnecessary whitespace and comments, along with minor formatting tweaks that do not affect functionality.
  • Removed .code-workspace. I believe this file should remain local, even with relative paths, it can still cause friction for anyone using VS Code with this repo.
  • (削除) Replaced all #!/bin/bash with #!/bin/sh, as I didn't find any Bash-specific features used in the scripts. (削除ここまで)
  • (削除) Removed /user.js since it's unused anywhere in the project. (削除ここまで)
Attempt to reduce the number of files in the repository. I also considered moving the macOS install/uninstall scripts to `/scripts`, but ultimately decided against it. - Removed unnecessary whitespace and comments, along with minor formatting tweaks that do not affect functionality. - Removed `.code-workspace`. I believe this file should remain local, even with relative paths, it can still cause friction for anyone using VS Code with this repo. - ~~Replaced all `#!/bin/bash` with `#!/bin/sh`, as I didn't find any Bash-specific features used in the scripts.~~ - ~~Removed `/user.js` since it's unused anywhere in the project.~~
celenity requested changes 2026年05月03日 09:38:11 +02:00
Dismissed
celenity left a comment
Copy link

Thank you!

Thank you!
user.js Outdated
@ -1 +0,0 @@
user_pref("autoadmin.global_config_url", "file://put_your_cfg_file_location_here");
Owner
Copy link

This file is actually used for manual installation of Phoenix Extended and specialized configs - see step 3 here. So we will need to keep it (We can consider moving it somewhere else though, doesn't necessarily need to be in the root).

This file is actually used for manual installation of Phoenix `Extended` and specialized configs - see [step 3 here](https://codeberg.org/celenity/Phoenix/src/branch/dev/docs/ManualInstallation.md#extended-specialized). So we will need to keep it *(We can consider moving it somewhere else though, doesn't necessarily need to be in the root)*.
Author
Contributor
Copy link

I think we should figure out a better location for user.js, but for now, it's probably best to leave it as is.

I think we should figure out a better location for `user.js`, but for now, it's probably best to leave it as is.
koru marked this conversation as resolved
First-time contributor
Copy link

Replaced all #!/bin/bash with #!/bin/sh, as I didn't find any Bash-specific features used in the scripts.

https://www.shellcheck.net/wiki/SC3051

also SC3001, SC3010, SC3014, SC2028 SC3040, SC3044 ...

easier to just keep the bash shebang

>Replaced all `#!/bin/bash` with `#!/bin/sh`, as I didn't find any Bash-specific features used in the scripts. https://www.shellcheck.net/wiki/SC3051 also [SC3001](https://www.shellcheck.net/wiki/SC3001), [SC3010](https://www.shellcheck.net/wiki/SC3010), [SC3014](https://www.shellcheck.net/wiki/SC3014), [SC2028](https://www.shellcheck.net/wiki/SC2028) [SC3040](https://www.shellcheck.net/wiki/SC3040), [SC3044](https://www.shellcheck.net/wiki/SC3044) ... easier to just keep the bash shebang
koru changed title from (削除) refactor: remove obsolete files, update scripts (削除ここまで) to WIP: refactor: remove obsolete files, update scripts 2026年05月13日 14:48:33 +02:00
koru changed title from (削除) WIP: refactor: remove obsolete files, update scripts (削除ここまで) to refactor: remove obsolete files, update scripts 2026年05月13日 15:39:08 +02:00
Author
Contributor
Copy link

I think PR is ready.

I think PR is ready.
celenity left a comment
Copy link

LGTM, thank you!!

LGTM, thank you!!
koru deleted branch obsolete 2026年05月14日 08:28:55 +02:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
celenity/Phoenix!286
Reference in a new issue
celenity/Phoenix
No description provided.
Delete branch "koru/Phoenix:obsolete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?