andromeda-fp/Phoenix:dev into dev this fixes the nix build on x86_64-linux by removing and regenerating the .zip file. it certaintly doesn't work on nix-darwin but I don't have a device to test it on. I don't think this changes any of the Phoenix functionality.
Thank you for submitting this!
I don't think a patch is the best solution here. What do you think about modifying gen-archive.sh directly and leveraging the PHOENIX_NIX environment variable instead? So, for example, maybe we could use something like this?:
if [ "${PHOENIX_NIX}" == 1 ]; then
readonly PHOENIX_ZIP='zip -r'
else
readonly PHOENIX_ZIP='zip -r -FS'
fi
Curious to hear your thoughts.
1c69c28a9b
to 14261d779b
that is a more elegant way of doing it, I agree. The reason to rm the zip file is that otherwise the following error gets thrown, whether with or without the -FS flag; afaik zip doesn't have any --overwrite sort of flag.
phoenix> Creating /build/qvz672gq8ldzzvb2k5w3bcnbyi8a3jmc-source/archives/phoenix-linux.zip...
phoenix> + zip -r /build/qvz672gq8ldzzvb2k5w3bcnbyi8a3jmc-source/archives/phoenix-linux.zip COPYING.txt README.md assets configs defaults etc phoenix.cfg policies resources unused userjs -x 'unused/*'
phoenix> zip warning: missing end signature--probably not a zip file (did you
phoenix> zip warning: remember to use binary mode when you transferred it?)
phoenix> zip warning: (if you are trying to read a damaged archive try -F)
phoenix>
phoenix> zip error: Zip file structure invalid (/build/qvz672gq8ldzzvb2k5w3bcnbyi8a3jmc-source/archives/phoenix-linux.zip)
LGTM, thank you!
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?