fix: re-commit .zip and .png files #262

koru commented 2026年04月14日 18:29:04 +02:00

Re-commit LFS files to fix broken stale (unstaged) files. @celenity, please check the images, maybe it will cause the build to fail or... not.

Re-commit LFS files to fix broken stale (unstaged) files. @celenity, please check the images, maybe it will cause the build to fail or... not.

koru commented 2026年04月17日 07:42:48 +02:00

@celenity wrote in #262 (comment):

@ivankopylov6603 I think it's a good idea to commit these as LFS files - but do you think there's a way we can still view/download the files directly from Codeberg? Here's an example of what I envision this looking like from the IronFox F-droid repo - we upload the .apk files there as LFS, but it's still possible to view/download them directly from the web - that doesn't seem to be the case with these files here for whatever reason.

I think I didn't commit correctly, it looks like they're broken. I'll figure out what happened.

And yes, here is an example of a working file.

@celenity wrote in https://codeberg.org/celenity/Phoenix/pulls/262#issuecomment-13233057: > @ivankopylov6603 I think it's a good idea to commit these as LFS files - but do you think there's a way we can still view/download the files directly from Codeberg? [Here's an example](https://codeberg.org/ironfox-oss/fdroid/src/branch/dev/fdroid/repo/ironfox-149.0-arm64-v8a.apk) of what I envision this looking like from the IronFox F-droid repo - we upload the `.apk` files there as LFS, but it's still possible to view/download them directly from the web - that doesn't seem to be the case with these files here for whatever reason. I think I didn't commit correctly, it looks like they're broken. I'll figure out what happened. And yes, here is an example of a [working file](https://codeberg.org/ivankopylov6603/FFmpegPlayer/src/branch/main/Resources/Icon128.png).

koru commented 2026年04月17日 08:43:06 +02:00

I tried to squash commits but had no luck. Apparently we'll have to leave 3 commits in the PR.

I tried to squash commits but had no luck. Apparently we'll have to leave 3 commits in the PR.

celenity commented 2026年04月17日 17:38:14 +02:00

It still doesn't look to be working quite right to me - ex..

It still doesn't look to be working quite right to me - [ex.](https://codeberg.org/celenity/Phoenix/src/commit/294010a28425145ce5eda752c21a04175aba3729/linux-flatpak/assets/phoenix.png).

koru commented 2026年04月17日 17:42:33 +02:00

@celenity wrote in #262 (comment):

It still doesn't look to be working quite right to me - ex..

See https://codeberg.org/ivankopylov6603/Phoenix/src/branch/lfs/linux-flatpak/assets/phoenix.png

Perhaps the problem is that you are looking at the commit, but I was looking at the fork branch and after the merge everything will be fine?

Edit: add text

@celenity wrote in https://codeberg.org/celenity/Phoenix/pulls/262#issuecomment-13264692: > It still doesn't look to be working quite right to me - [ex.](https://codeberg.org/celenity/Phoenix/src/commit/294010a28425145ce5eda752c21a04175aba3729/linux-flatpak/assets/phoenix.png). See https://codeberg.org/ivankopylov6603/Phoenix/src/branch/lfs/linux-flatpak/assets/phoenix.png Perhaps the problem is that you are looking at the commit, but I was looking at the fork branch and after the merge everything will be fine? Edit: add text

celenity commented 2026年04月17日 17:46:19 +02:00

@ivankopylov6603 wrote in #262 (comment):

@celenity wrote in #262 (comment):

It still doesn't look to be working quite right to me - ex..

See https://codeberg.org/ivankopylov6603/Phoenix/src/branch/lfs/linux-flatpak/assets/phoenix.png

Interesting, I'm guessing it's just a bug with Forgejo and specific to the view in the MR then?

Since it looks good in your branch directly, I'll go ahead and merge (since it'll be in the dev branch, we can still make changes if we find it causes issues), thank you for your time/work here!

@ivankopylov6603 wrote in https://codeberg.org/celenity/Phoenix/pulls/262#issuecomment-13264791: > @celenity wrote in #262 (comment): > > > It still doesn't look to be working quite right to me - [ex.](https://codeberg.org/celenity/Phoenix/src/commit/294010a28425145ce5eda752c21a04175aba3729/linux-flatpak/assets/phoenix.png). > > See https://codeberg.org/ivankopylov6603/Phoenix/src/branch/lfs/linux-flatpak/assets/phoenix.png Interesting, I'm guessing it's just a bug with Forgejo and specific to the view in the MR then? Since it looks good in your branch directly, I'll go ahead and merge *(since it'll be in the `dev` branch, we can still make changes if we find it causes issues)*, thank you for your time/work here!

celenity commented 2026年04月17日 17:48:19 +02:00

Yep, looks good after merging!

Yep, [looks good after merging](https://codeberg.org/celenity/Phoenix/src/branch/dev/build-resources/assets/phoenix.png)!