9
2
Fork
You've already forked platform
2

fix(gateway): use git-safe deploy progress #359

Manually merged
ryansquared merged 1 commit from fix/issue-348-git-progress-checklist into main 2026年07月06日 21:35:57 +02:00

Summary

  • replace animated Git deploy progress spinners with line-oriented checklist messages
  • remove carriage-return based remote progress updates from the gateway SSH deploy stream
  • add a regression test that deploy progress messages remain remote:-prefixed, newline-terminated, and free of non-line terminal controls

Fixes #348

Test plan

  • rustfmt --edition 2021 src/gateway/src/ssh_server.rs
  • cargo test -p gateway deploy_progress_messages_are_git_safe_line_output -- --nocapture
  • cargo test -p gateway ssh_server::tests -- --nocapture
  • cargo test -p gateway
  • cargo clippy -p gateway --all-targets
  • git diff --check

Notes: gateway clippy passes with existing warnings in unrelated code.

## Summary - replace animated Git deploy progress spinners with line-oriented checklist messages - remove carriage-return based remote progress updates from the gateway SSH deploy stream - add a regression test that deploy progress messages remain `remote:`-prefixed, newline-terminated, and free of non-line terminal controls Fixes #348 ## Test plan - `rustfmt --edition 2021 src/gateway/src/ssh_server.rs` - `cargo test -p gateway deploy_progress_messages_are_git_safe_line_output -- --nocapture` - `cargo test -p gateway ssh_server::tests -- --nocapture` - `cargo test -p gateway` - `cargo clippy -p gateway --all-targets` - `git diff --check` Notes: gateway clippy passes with existing warnings in unrelated code.
ryansquared manually merged commit fbe0fcb62c into main 2026年07月06日 21:35:57 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Component/Enclave-Builder
This issue affects Enclave Builder (git-push and CLI)
Component/Infrastructure
This issue affects generic Caution hosted infra components
Deploy/BYOC
Relates to Caution Bring-your-own-compute
Deploy/Full-managed
Relates to Caution fully managed cloud
Deploy/Self-hosted
Relates to Caution deployed on self-hosted infra
Interface/API
This issue affects the API
Interface/CLI
This issue affects the command line interface
Interface/Git
This issue affects the Git `push` interface
Interface/Web
This issue affects the web dashboard
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
caution/platform!359
Reference in a new issue
caution/platform
No description provided.
Delete branch "fix/issue-348-git-progress-checklist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?