9
2
Fork
You've already forked platform
2

fix/cli-hangs-unsupported-ssh-url + TOFU #341

Manually merged
ryansquared merged 4 commits from fix/cli-hangs-unsupported-ssh-url into main 2026年07月03日 16:15:01 +02:00

When a manifest's app source uses an ssh:// URL, caution verify could hang waiting for an interactive SSH prompt (host key TOFU or credentials). Three fixes:

  • git_url_to_archive_urls now parses ssh:// scheme URLs, so archive download is attempted before falling back to git clone
  • git_command sets GIT_TERMINAL_PROMPT=0, GIT_ASKPASS=true, and GIT_SSH_COMMAND with BatchMode=yes to prevent SSH from prompting via /dev/tty
  • StrictHostKeyChecking=accept-new — explicit TOFU: unknown hosts are accepted on first contact, changed keys are rejected (MITM protection); existing GIT_SSH_COMMAND from the caller's env is preserved and extended rather than replaced
When a manifest's app source uses an `ssh://` URL, `caution verify` could hang waiting for an interactive SSH prompt (host key TOFU or credentials). Three fixes: - `git_url_to_archive_urls` now parses `ssh://` scheme URLs, so archive download is attempted before falling back to git clone - `git_command` sets `GIT_TERMINAL_PROMPT=0`, `GIT_ASKPASS=true`, and `GIT_SSH_COMMAND` with `BatchMode=yes` to prevent SSH from prompting via `/dev/tty` - `StrictHostKeyChecking=accept-new` — explicit TOFU: unknown hosts are accepted on first contact, changed keys are rejected (MITM protection); existing `GIT_SSH_COMMAND` from the caller's env is preserved and extended rather than replaced
@ -2359,3 +2359,3 @@
.ok_or_else(||anyhow::anyhow!("Invalid git SSH URL format"))?;
(host.to_string(),path.trim_end_matches(".git").to_string())
}elseifgit_url.starts_with("https://")||git_url.starts_with("http://"){
}elseifgit_url.starts_with("ssh://")||git_url.starts_with("https://")||git_url.starts_with("http://"){

why are we parsing git urls and converting them to https?

why are we parsing git urls and converting them to https?
Author
Owner
Copy link

Fixed ssh:// sources now skip the HTTP archive-guessing and go straight to git clone

Fixed ssh:// sources now skip the HTTP archive-guessing and go straight to git clone
An ssh:// URL implies an authenticated clone is expected; probing
anonymous HTTP(S) archive endpoints first just wastes round trips
before falling back to git clone.
ryansquared manually merged commit bb86f07c90 into main 2026年07月03日 16:15:01 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Component/Enclave-Builder
This issue affects Enclave Builder (git-push and CLI)
Component/Infrastructure
This issue affects generic Caution hosted infra components
Deploy/BYOC
Relates to Caution Bring-your-own-compute
Deploy/Full-managed
Relates to Caution fully managed cloud
Deploy/Self-hosted
Relates to Caution deployed on self-hosted infra
Interface/API
This issue affects the API
Interface/CLI
This issue affects the command line interface
Interface/Git
This issue affects the Git `push` interface
Interface/Web
This issue affects the web dashboard
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
caution/platform!341
Reference in a new issue
caution/platform
No description provided.
Delete branch "fix/cli-hangs-unsupported-ssh-url"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?