9
2
Fork
You've already forked platform
2

caution-config: validate domain and provider IDs at parse time #328

Manually merged
ryansquared merged 2 commits from fix/config-domain-validation into main 2026年06月29日 07:11:22 +02:00

domain and the provider AWS ids (vpc_id, subnet_ids, security_group_id) flow unescaped into generated Terraform, the bootstrap script, and the Caddy config. Validate them at parse time (Procfile + HCL) — strict DNS name for domain, strict -<8|17 hex> for the ids so no shell/HCL metacharacters survive parsing

domain and the provider AWS ids (vpc_id, subnet_ids, security_group_id) flow unescaped into generated Terraform, the bootstrap script, and the Caddy config. Validate them at parse time (Procfile + HCL) — strict DNS name for domain, strict <prefix>-<8|17 hex> for the ids so no shell/HCL metacharacters survive parsing
The domain is interpolated into generated Terraform vars, the instance bootstrap script, and the Caddy config, so reject anything that isn't a plain DNS name at parse time (both Procfile and HCL paths)
vkobel changed title from (削除) caution-config: validate http domain as a hostname (削除ここまで) to caution-config: validate domain and provider IDs at parse time 2026年06月27日 09:52:30 +02:00
Author
Owner
Copy link

We should probably have a look at current domains and values to ensure no deployed app have weird looking patterns in what is fixed here

We should probably have a look at current domains and values to ensure no deployed app have weird looking patterns in what is fixed here
vkobel force-pushed fix/config-domain-validation from 28a4bce8e0 to 7c3a8cdcd9 2026年06月27日 09:59:04 +02:00 Compare
ryansquared manually merged commit b5d6e675e0 into main 2026年06月29日 07:11:22 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Component/Enclave-Builder
This issue affects Enclave Builder (git-push and CLI)
Component/Infrastructure
This issue affects generic Caution hosted infra components
Deploy/BYOC
Relates to Caution Bring-your-own-compute
Deploy/Full-managed
Relates to Caution fully managed cloud
Deploy/Self-hosted
Relates to Caution deployed on self-hosted infra
Interface/API
This issue affects the API
Interface/CLI
This issue affects the command line interface
Interface/Git
This issue affects the Git `push` interface
Interface/Web
This issue affects the web dashboard
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
caution/platform!328
Reference in a new issue
caution/platform
No description provided.
Delete branch "fix/config-domain-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?