9
2
Fork
You've already forked platform
2

fix/procfile-run-command-no-split #318

Manually merged
ryansquared merged 8 commits from fix/procfile-run-command-no-split into main 2026年06月26日 07:42:53 +02:00

from_procfile shlex-split run: into command + args, but the deploy path only runs command via sh -c and ignores args. So everything after the first token got dropped — run: /app --port 8080 ran as sh -c '/app', and FOO=1 /app became sh -c 'FOO=1' (binary never started)

Fix: keep the whole run: string in command.

Follow up bug found, here: #319

from_procfile shlex-split run: into command + args, but the deploy path only runs command via sh -c and ignores args. So everything after the first token got dropped — run: /app --port 8080 ran as sh -c '/app', and FOO=1 /app became sh -c 'FOO=1' (binary never started) Fix: keep the whole run: string in command. Follow up bug found, here: https://codeberg.org/caution/platform/issues/319
Deploy path runs unit.command via sh -c and ignores args, so the split dropped everything after the first token at deploy time

we need to keep the shlex split and quote to support automatic escaping of commands. can you readjust this to instead properly include all the necessary values?

we need to keep the shlex split and quote to support automatic escaping of commands. can you readjust this to instead properly include all the necessary values?
NAME=value tokens before the binary (e.g. FOO=1 /app) must be emitted verbatim with only the value quoted; quoting the whole token makes the shell run 'FOO=1' as a command. Also catch invalid env keys at parse time and error when no executable is left after consuming env prefixes.
ryansquared manually merged commit ee922b964d into main 2026年06月26日 07:42:53 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Component/Enclave-Builder
This issue affects Enclave Builder (git-push and CLI)
Component/Infrastructure
This issue affects generic Caution hosted infra components
Deploy/BYOC
Relates to Caution Bring-your-own-compute
Deploy/Full-managed
Relates to Caution fully managed cloud
Deploy/Self-hosted
Relates to Caution deployed on self-hosted infra
Interface/API
This issue affects the API
Interface/CLI
This issue affects the command line interface
Interface/Git
This issue affects the Git `push` interface
Interface/Web
This issue affects the web dashboard
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
caution/platform!318
Reference in a new issue
caution/platform
No description provided.
Delete branch "fix/procfile-run-command-no-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?