9
2
Fork
You've already forked platform
2

fix/keygen-add-signing-subkey #285

Manually merged
anton merged 4 commits from vkobel/caution-platform:fix/keygen-add-signing-subkey into main 2026年06月12日 15:21:48 +02:00

fix: make send-shard work with locally generated keyrings

  • Added a signing subkey to secret keygen --shoot-self-in-foot — generated certs had only encrypt/auth keys, so shard holders could never sign a send-shard request; locksmith found no signing-capable key and failed with the cryptic NoMatchingCard.
  • Required signing capability in the keyring eligibility check — secret new now rejects sign-less certs upfront with a clear error, instead of letting a quorum be built, deployed, and discovered dead only at shard-sending time.
  • Normalized keyrings into a single armor block in secret new — assembling a keyring with cat alice.asc bob.asc (the documented flow) creates multiple armor blocks; gpg/sequoia read them all but the rpgp-based Keymaker/Locksmith stack silently keeps only one cert, locking the dropped holders out of the quorum.
  • Bumped the locksmith pin to 6918ad9 — that revision implements signing with a local private key file (--keyring); lockfile-respecting builds would otherwise compile the older locksmith without the feature the whole flow depends on.
  • Extended the secret new e2e test — fixed its test keyring (no signing subkey, so it would now be rejected), and added regression coverage for both bugs: concatenated keyrings must end up as one armor block in the bundle, and sign-less keyrings must be rejected.
fix: make send-shard work with locally generated keyrings - Added a signing subkey to secret keygen --shoot-self-in-foot — generated certs had only encrypt/auth keys, so shard holders could never sign a send-shard request; locksmith found no signing-capable key and failed with the cryptic NoMatchingCard. - Required signing capability in the keyring eligibility check — secret new now rejects sign-less certs upfront with a clear error, instead of letting a quorum be built, deployed, and discovered dead only at shard-sending time. - Normalized keyrings into a single armor block in secret new — assembling a keyring with cat alice.asc bob.asc ([the documented flow](https://codeberg.org/caution/docs/pulls/17)) creates multiple armor blocks; gpg/sequoia read them all but the rpgp-based Keymaker/Locksmith stack silently keeps only one cert, locking the dropped holders out of the quorum. - Bumped the locksmith pin to 6918ad9 — that revision implements signing with a local private key file (--keyring); lockfile-respecting builds would otherwise compile the older locksmith without the feature the whole flow depends on. - Extended the secret new e2e test — fixed its test keyring (no signing subkey, so it would now be rejected), and added regression coverage for both bugs: concatenated keyrings must end up as one armor block in the bundle, and sign-less keyrings must be rejected.
Concatenated armored keyrings (cat alice.asc bob.asc) are read fully by
sequoia/gpg but the rpgp-based Keymaker/Locksmith stack only parses the
first block, silently dropping holders and breaking their send-shard.
Add a signing subkey to the test keyring (now required for eligibility),
test that concatenated keyrings are normalized to one armor block, and
that sign-less keyrings are rejected.
anton manually merged commit a25c6ea927 into main 2026年06月12日 15:21:48 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Component/Enclave-Builder
This issue affects Enclave Builder (git-push and CLI)
Component/Infrastructure
This issue affects generic Caution hosted infra components
Deploy/BYOC
Relates to Caution Bring-your-own-compute
Deploy/Full-managed
Relates to Caution fully managed cloud
Deploy/Self-hosted
Relates to Caution deployed on self-hosted infra
Interface/API
This issue affects the API
Interface/CLI
This issue affects the command line interface
Interface/Git
This issue affects the Git `push` interface
Interface/Web
This issue affects the web dashboard
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
caution/platform!285
Reference in a new issue
caution/platform
No description provided.
Delete branch "vkobel/caution-platform:fix/keygen-add-signing-subkey"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?