Add public certificate contract models #8

caution-bot commented 2026年07月15日 01:11:23 +02:00

Summary

• Add shared keymaker-models::public_certificates request and response types for the public certificate derivation API.
• Encode the reviewed v1 contract shape: data plus top-level necroproof, strict request fields, certificate entries with index and armored_certificate, and no trusted derivation path/fingerprint/signature metadata fields.
• Add validation helpers for certificate count, UTC expiration bounds, payload version/profile/count/order, canonical UUID parsing, and masked UUID-derived account indices for the m/pgp'/kmkr'/... namespace.

Test plan

• rustfmt --edition 2024 --check crates/keymaker-models/src/lib.rs
• git diff --check
• cargo test -p keymaker-models
• cargo clippy -p keymaker-models --all-targets -- -D warnings
• cargo test --workspace (passes; existing warnings remain for minipgp6 cfg, unused now, unreachable reboot expression, unused secrets, and unused get_shards_test_util)

Deferred follow-ups

• Add the actual public certificate service process, HTTP route, Locksmith/Keyfork readiness flow, CA UID certification embedding, and necroproof computation.
• Select or implement the shared deterministic structure-hash/necroproof registry before producing real artifacts.

Refs caution/platform#383

## Summary - Add shared `keymaker-models::public_certificates` request and response types for the public certificate derivation API. - Encode the reviewed v1 contract shape: `data` plus top-level `necroproof`, strict request fields, certificate entries with `index` and `armored_certificate`, and no trusted derivation path/fingerprint/signature metadata fields. - Add validation helpers for certificate count, UTC expiration bounds, payload version/profile/count/order, canonical UUID parsing, and masked UUID-derived account indices for the `m/pgp'/kmkr'/...` namespace. ## Test plan - `rustfmt --edition 2024 --check crates/keymaker-models/src/lib.rs` - `git diff --check` - `cargo test -p keymaker-models` - `cargo clippy -p keymaker-models --all-targets -- -D warnings` - `cargo test --workspace` (passes; existing warnings remain for `minipgp6` cfg, unused `now`, unreachable reboot expression, unused `secrets`, and unused `get_shards_test_util`) ## Deferred follow-ups - Add the actual public certificate service process, HTTP route, Locksmith/Keyfork readiness flow, CA UID certification embedding, and necroproof computation. - Select or implement the shared deterministic structure-hash/necroproof registry before producing real artifacts. Refs https://codeberg.org/caution/platform/issues/383

caution-bot commented 2026年07月15日 03:50:58 +02:00

Addressed the review comments in commit 64bf509f8c8c76f376f1bd2c1536dc7d643a2e4a:

• Moved the public certificate contract into a dedicated public-certificate-models crate instead of keymaker-models.
• Removed validation/derivation business logic from the model crate.
• Removed response certificate_count; callers can derive it from certificates.len().
• Documented the public contract fields, including certificate_profile.
• Removed the response-level certificate index; the model now documents that the immutable index belongs inside the OpenPGP certificate self-notation.

Verification:

• rustfmt --edition 2024 crates/public-certificate-models/src/lib.rs crates/keymaker-models/src/lib.rs
• cargo check --workspace
• cargo test -p public-certificate-models
• cargo test -p keymaker-models
• git diff --check

All passed; cargo check --workspace still reports pre-existing warnings in keymaker/locksmith unrelated to this patch.

Addressed the review comments in commit `64bf509f8c8c76f376f1bd2c1536dc7d643a2e4a`: - Moved the public certificate contract into a dedicated `public-certificate-models` crate instead of `keymaker-models`. - Removed validation/derivation business logic from the model crate. - Removed response `certificate_count`; callers can derive it from `certificates.len()`. - Documented the public contract fields, including `certificate_profile`. - Removed the response-level certificate `index`; the model now documents that the immutable index belongs inside the OpenPGP certificate self-notation. Verification: - `rustfmt --edition 2024 crates/public-certificate-models/src/lib.rs crates/keymaker-models/src/lib.rs` - `cargo check --workspace` - `cargo test -p public-certificate-models` - `cargo test -p keymaker-models` - `git diff --check` All passed; `cargo check --workspace` still reports pre-existing warnings in `keymaker`/`locksmith` unrelated to this patch.

caution-bot commented 2026年07月15日 05:21:17 +02:00

Follow-up pushed in commit ab0117c0a23d3302bd2a7f19cfc64f23ffdf460e after re-checking the inline review thread.

The dedicated public-certificate-models crate is now data-only: I removed the custom UUID/timestamp deserializers and the validation-oriented tests so the crate just carries the request/response contract and field documentation. The previous changes still keep certificate_count out of the response and keep certificate indexes inside the OpenPGP certificate self-notation rather than as response fields.

Verification:

• rustfmt --edition 2024 crates/public-certificate-models/src/lib.rs
• cargo check --workspace
• cargo test -p public-certificate-models
• git diff --check

All passed; cargo check --workspace still reports the same pre-existing warnings in keymaker/locksmith.

Follow-up pushed in commit `ab0117c0a23d3302bd2a7f19cfc64f23ffdf460e` after re-checking the inline review thread. The dedicated `public-certificate-models` crate is now data-only: I removed the custom UUID/timestamp deserializers and the validation-oriented tests so the crate just carries the request/response contract and field documentation. The previous changes still keep `certificate_count` out of the response and keep certificate indexes inside the OpenPGP certificate self-notation rather than as response fields. Verification: - `rustfmt --edition 2024 crates/public-certificate-models/src/lib.rs` - `cargo check --workspace` - `cargo test -p public-certificate-models` - `git diff --check` All passed; `cargo check --workspace` still reports the same pre-existing warnings in `keymaker`/`locksmith`.

This pull request can be merged automatically.

You are not authorized to merge this pull request.