bookstack/bookstack
20
204
Fork
You've already forked bookstack
20

Update resources/views/layouts/parts/header-logo.blade.php for accessibility issue #6165

Open
magordon wants to merge 1 commit from magordon/bookstack:development into development
pull from: magordon/bookstack:development
merge into: bookstack:development
bookstack:development
bookstack:l10n_development
bookstack:release
bookstack:snyk-action
bookstack:ci_and_static
bookstack:mfa_key
bookstack:phpstan_june26
bookstack:llm_only
bookstack:vectors
bookstack:captcha_example
First-time contributor
Copy link

We had a review by our accessibility team, and overall Bookstack is doing great! However the logo is a bit of an issue for them, since the descriptive alt tag is not descriptive enough as "Logo". Ideally we would like to either extend bookstack to allow the alt tag to be customizable, remove the alt tag and replace with aria-hidden="true", or blank the alt tag so screen readers ignore it. I opted for aria-hidden. I am open to looking into extending the config to allow for it to be configured, but figured I'd try the simplest option first...

Details

We had a review by our accessibility team, and overall Bookstack is doing great! However the logo is a bit of an issue for them, since the descriptive alt tag is not descriptive enough as "Logo". Ideally we would like to either extend bookstack to allow the alt tag to be customizable, remove the alt tag and replace with aria-hidden="true", or blank the alt tag so screen readers ignore it. I opted for aria-hidden. I am open to looking into extending the config to allow for it to be configured, but figured I'd try the simplest option first...

Thank you for all your work on this app!

Checklist

  • I have read the BookStack community rules.
  • This PR does not feature significant use of LLM/AI generation as per the community rules above.
We had a review by our accessibility team, and overall Bookstack is doing great! However the logo is a bit of an issue for them, since the descriptive alt tag is not descriptive enough as "Logo". Ideally we would like to either extend bookstack to allow the alt tag to be customizable, remove the alt tag and replace with aria-hidden="true", or blank the alt tag so screen readers ignore it. I opted for aria-hidden. I am open to looking into extending the config to allow for it to be configured, but figured I'd try the simplest option first... ## Details <!-- Write details of your pull request in here --> We had a review by our accessibility team, and overall Bookstack is doing great! However the logo is a bit of an issue for them, since the descriptive alt tag is not descriptive enough as "Logo". Ideally we would like to either extend bookstack to allow the alt tag to be customizable, remove the alt tag and replace with aria-hidden="true", or blank the alt tag so screen readers ignore it. I opted for aria-hidden. I am open to looking into extending the config to allow for it to be configured, but figured I'd try the simplest option first... Thank you for all your work on this app! <!-- Include references to any relevant issues/discussions --> ## Checklist <!-- Put an 'x' in between the brackets below to confirm these elements --> - [x] I have read the [BookStack community rules](https://www.bookstackapp.com/about/community-rules/). - [x] This PR does not feature significant use of LLM/AI generation as per the community rules above.
Update resources/views/layouts/parts/header-logo.blade.php
Some checks are pending
analyse-php / build (pull_request) Blocked by required conditions
lint-php / build (pull_request) Blocked by required conditions
test-migrations / build (8.2) (pull_request) Blocked by required conditions
test-migrations / build (8.3) (pull_request) Blocked by required conditions
test-migrations / build (8.4) (pull_request) Blocked by required conditions
test-migrations / build (8.5) (pull_request) Blocked by required conditions
test-php / build (8.2) (pull_request) Blocked by required conditions
test-php / build (8.3) (pull_request) Blocked by required conditions
test-php / build (8.4) (pull_request) Blocked by required conditions
test-php / build (8.5) (pull_request) Blocked by required conditions
49293a8f38 
We had a review by accessibility team, and overall Bookstack is doing great, however the logo is a bit of an issue for them, since the descriptive alt tag is not descriptive enough. Ideally we would like to either extend bookstack to allow the alt tag to be customizable, remove the alt tag and replace with aria-hidden="true", or blank the alt tag so screen readers ignore it.
Some checks are pending
analyse-php / build (pull_request) Blocked by required conditions
lint-php / build (pull_request) Blocked by required conditions
test-migrations / build (8.2) (pull_request) Blocked by required conditions
test-migrations / build (8.3) (pull_request) Blocked by required conditions
test-migrations / build (8.4) (pull_request) Blocked by required conditions
test-migrations / build (8.5) (pull_request) Blocked by required conditions
test-php / build (8.2) (pull_request) Blocked by required conditions
test-php / build (8.3) (pull_request) Blocked by required conditions
test-php / build (8.4) (pull_request) Blocked by required conditions
test-php / build (8.5) (pull_request) Blocked by required conditions
This pull request can be merged automatically.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u development:magordon-development
git switch magordon-development

Merge

Merge the changes and update on Forgejo.
git switch development
git merge --no-ff magordon-development
git switch magordon-development
git rebase development
git switch development
git merge --ff-only magordon-development
git switch magordon-development
git rebase development
git switch development
git merge --no-ff magordon-development
git switch development
git merge --squash magordon-development
git switch development
git merge --ff-only magordon-development
git switch development
git merge magordon-development
git push origin development
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bookstack/bookstack!6165
Reference in a new issue
bookstack/bookstack
No description provided.
Delete branch "magordon/bookstack:development"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?