feat : add an option to patch ST-LinkV2 app firmware on the fly to make the bootloader recognise it as valid #1

freeman1216 commented 2026年04月03日 03:21:40 +02:00

feat : add an option to patch ST-LinkV2 app firmware on the fly to make the bootloader recognise it as valid

dunno if it is possible to build on Windows with all those posix calls, maybe its time to ditch those since we no longer map the file and so dont need the fd

feat : add an option to patch ST-LinkV2 app firmware on the fly to make the bootloader recognise it as valid dunno if it is possible to build on Windows with all those posix calls, maybe its time to ditch those since we no longer map the file and so dont need the fd

dragonmux commented 2026年04月04日 04:14:55 +02:00

Please use tabs, not spaces, for your indentation - trying to understand the diffs is being hampered here by your changing indentation over.. lots of noise in the diff as a result.

Please use tabs, not spaces, for your indentation - trying to understand the diffs is being hampered here by your changing indentation over.. lots of noise in the diff as a result.

freeman1216 commented 2026年04月04日 14:25:12 +02:00

My bad, should have checked first

My bad, should have checked first

dragonmux commented 2026年04月04日 14:27:52 +02:00

That's okay - it looks like you're running some form of clang-format? Could we ask you grab the config for it from the main BMD repo and use that for this one - it should probably get committed as a file in the root of this repo, but it didn't yet get done. The reason for saying/asking is that it's reformatting the switch/case statement which is still causing a large amount of noise.

That'll also happen to fix all the formatting notes we would otherwise create and which are the only kind of note we can see creating for this PR - meaning, with that done we can then approve it and merge.

Once that's done, could we have you please apply your fixup commits as fixups to the base commits they change, as we won't be squashing when we merge - our policy, because having git blame and such work in a reasonable way is important to us, is to fast-forward merge only, or otherwise rebase then fast-forward.

That's okay - it looks like you're running some form of `clang-format`? Could we ask you grab the config for it from the main BMD repo and use that for this one - it should probably get committed as a file in the root of this repo, but it didn't yet get done. The reason for saying/asking is that it's reformatting the `switch`/`case` statement which is still causing a large amount of noise. That'll also happen to fix all the formatting notes we would otherwise create and which are the only kind of note we can see creating for this PR - meaning, with that done we can then approve it and merge. Once that's done, could we have you please apply your fixup commits as fixups to the base commits they change, as we won't be squashing when we merge - our policy, because having `git blame` and such work in a reasonable way is important to us, is to fast-forward merge only, or otherwise rebase then fast-forward.

freeman1216 commented 2026年04月04日 23:02:38 +02:00

Hope that does it, i am not that experienced with this so thanks for bearing with me

I am not quite happy with the ux though, specifing size is kinda annoying, maybe i can get this info from bl info, i ll try to triage this and if i find something ill make another pr (better formated then this one)

Hope that does it, i am not that experienced with this so thanks for bearing with me I am not quite happy with the ux though, specifing size is kinda annoying, maybe i can get this info from bl info, i ll try to triage this and if i find something ill make another pr (better formated then this one)