Visit Page
4
1
Fork
You've already forked pages
2

theme: Initial switch to furo theme. #60

Merged
esden merged 14 commits from switch-to-furo into main 2025年10月17日 06:43:48 +02:00
esden commented 2025年07月21日 02:06:57 +02:00 (Migrated from github.com)
Copy link

More work still needed, thus I am making it a draft.

The page now at least renders, and we are using a patched version of ablog.

There are some fonts that look out of place though, and need to be worked on.

We also should adjust the colors a bit to match the project better.

More work still needed, thus I am making it a draft. The page now at least renders, and we are using a patched version of ablog. There are some fonts that look out of place though, and need to be worked on. We also should adjust the colors a bit to match the project better.
lethalbit left a comment
Copy link

Just a heads up, sphinxcontrib.platformpicker doesn't work on Furo, you'll want to replace it with sphinx_inline_tabs

Just a heads up, `sphinxcontrib.platformpicker` doesn't work on Furo, you'll want to replace it with `sphinx_inline_tabs`
esden commented 2025年10月16日 04:54:19 +02:00 (Migrated from github.com)
Copy link

ok, made some good progress. Still asciinema is broken. Needs to be fixed but I ran out of time for today :(

ok, made some good progress. Still asciinema is broken. Needs to be fixed but I ran out of time for today :(
dragonmux left a comment
Copy link

Only a couple of things of note to us that want looking at, other than that though this all looks good to us 👍🏼

Only a couple of things of note to us that want looking at, other than that though this all looks good to us 👍🏼
@ -0,0 +1,20 @@
[project]

Is this strictly required? Because here we're on Python 3.13 and this would prevent us being able to build the website locally when we can right now.

Is this strictly required? Because here we're on Python 3.13 and this would prevent us being able to build the website locally when we can right now.

You should be able to specify this as a normal dependency using git+https://github.com/ABD-01/ablog_with_furo@ablog_with_furo#egg=ablog - this should make the package manager do the right thing.

You should be able to specify this as a normal dependency using `git+https://github.com/ABD-01/ablog_with_furo@ablog_with_furo#egg=ablog` - this should make the package manager do the right thing.
esden (Migrated from github.com) reviewed 2025年10月16日 19:12:12 +02:00
@ -0,0 +1,20 @@
[project]
esden (Migrated from github.com) commented 2025年10月16日 19:12:12 +02:00
Copy link

good point, I think I fixed that one.

good point, I think I fixed that one.
esden (Migrated from github.com) reviewed 2025年10月16日 19:38:14 +02:00
@ -0,0 +1,20 @@
[project]
esden (Migrated from github.com) commented 2025年10月16日 19:38:14 +02:00
Copy link

this was automatically set by uv init, what version do you think will be sufficient to set here? I guess I could remove it all together, but maybe there should be some reasonable minimum.

this was automatically set by `uv init`, what version do you think will be sufficient to set here? I guess I could remove it all together, but maybe there should be some reasonable minimum.
@ -0,0 +1,20 @@
[project]
Contributor
Copy link

A reasonable minimum is either 3.10 or 3.11 as far as I can tell, depends on platform, but I think 3.11 is a good min, we use that for Torii et. al.

A reasonable minimum is either 3.10 or 3.11 as far as I can tell, depends on platform, but I think 3.11 is a good min, we use that for Torii et. al.
@ -0,0 +1,20 @@
[project]

Agreed with Aki - 3.11 was working to build this just prior to the Debian upgrade we did, so should be a decent default for minimum Python version.

Agreed with Aki - 3.11 was working to build this just prior to the Debian upgrade we did, so should be a decent default for minimum Python version.
esden (Migrated from github.com) reviewed 2025年10月16日 21:14:36 +02:00
@ -0,0 +1,20 @@
[project]
esden (Migrated from github.com) commented 2025年10月16日 21:14:36 +02:00
Copy link

ok, sounds good, will make the adjustment shortly

ok, sounds good, will make the adjustment shortly
esden (Migrated from github.com) reviewed 2025年10月16日 22:12:23 +02:00
@ -0,0 +1,20 @@
[project]
esden (Migrated from github.com) commented 2025年10月16日 22:12:23 +02:00
Copy link

ok, that is now done too :)

ok, that is now done too :)
esden commented 2025年10月16日 23:16:11 +02:00 (Migrated from github.com)
Copy link

@lethalbit we actually were not using the platformpicker anywhere in the website 🙃

I have still switched it over to inline tabs, and used it to do some compacting of the upgrade documentation.

It all needs further polish.

@lethalbit we actually were not using the platformpicker anywhere in the website 🙃 I have still switched it over to inline tabs, and used it to do some compacting of the upgrade documentation. It all needs further polish.
esden commented 2025年10月16日 23:17:45 +02:00 (Migrated from github.com)
Copy link

Ok, I think it is good enough for the moment. It should be at least equivalent to the previous version of the website regarding content.

The parts generated by ablog need some font size/spacing love, but it does not seem like a showstopper to me.

Ok, I think it is good enough for the moment. It should be at least equivalent to the previous version of the website regarding content. The parts generated by ablog need some font size/spacing love, but it does not seem like a showstopper to me.
dragonmux left a comment
Copy link

Only got the one note, and with that taken care of we'll be happy to get this merged.

Only got the one note, and with that taken care of we'll be happy to get this merged.
@ -58,6 +57,7 @@ todo_include_todos = True
myst_heading_anchors = 3

This appears to use different indentation to the line above it? (uses spaces, not tabs - or, more accurately, the line above it uses tabs not spaces)

This appears to use different indentation to the line above it? (uses spaces, not tabs - or, more accurately, the line above it uses tabs not spaces)
esden (Migrated from github.com) reviewed 2025年10月17日 06:23:08 +02:00
@ -58,6 +57,7 @@ todo_include_todos = True
myst_heading_anchors = 3
esden (Migrated from github.com) commented 2025年10月17日 06:23:08 +02:00
Copy link

good point. should be fixed now

good point. should be fixed now
dragonmux left a comment
Copy link

LGTM, merging. Nice job with upgrading and updating the website!

LGTM, merging. Nice job with upgrading and updating the website!
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/pages!60
Reference in a new issue
blackmagic-debug/pages
No description provided.
Delete branch "switch-to-furo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?