Since the new bmputil v1 now supports automatic firmware updates we should promote that as the best way to keep the Black Magic Probe current.
upgrade: Update the documentation to promote bmputil v1 use. #58
doc/update-instructions-for-bmputil-v1 into main @ -1,35 +1,126 @@
# Firmware Upgrade
This is an over-long line - we suggest inserting a new line just before the link text to get it to flow more nicely
to the latest release candidate? (Given this won't just pick an arbitrary one)
It's usually bleeding edge or cutting edge, not both for the expression.. We'd suggest going for cutting edge in this context.
Might be worth linking to nightly.link here instead so this can be done without a GH account?
@ -4,0 +16,4 @@
We recommend the following order of operations:
* [Install rustup](https://rustup.rs/)
* [Install cargo-binstall](https://github.com/cargo-bins/cargo-binstall?tab=readme-ov-file#installation)
nitpick: Missing new line before this for Markdown lint happiness
@ -4,3 +97,4 @@
### Download or build the firmware
Download or compile the Black Magic Debug (BMD) firmware. Regarding firmware selection:
nitpick: Missing new line before this line (Markdown lint)
Had meant to comment on submitting the review: This is generally looking really good - there are just a handful of fairly small things that might do with tweaking and then we can merge this.
@ -4,0 +16,4 @@
We recommend the following order of operations:
* [Install rustup](https://rustup.rs/)
* [Install cargo-binstall](https://github.com/cargo-bins/cargo-binstall?tab=readme-ov-file#installation)
sounds good :)
@ -1,35 +1,126 @@
# Firmware Upgrade
Yeah forgot to go over and reindent the paragraphs in general.
@ -1,35 +1,126 @@
# Firmware Upgrade
Fixed. :)
@ -1,35 +1,126 @@
# Firmware Upgrade
Good point. Fixed :)
@ -1,35 +1,126 @@
# Firmware Upgrade
Added, good idea. :)
@ -1,35 +1,126 @@
# Firmware Upgrade
Missing opening [ here to make this a README link.
@ -1,35 +1,126 @@
# Firmware Upgrade
how about now? :D
@ -1,35 +1,126 @@
# Firmware Upgrade
That'll do the trick ^_^
This all LGTM, merging. Thank you for sorting this out in light of the bmputil release! 🙂
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?