4
1
Fork
You've already forked libusb
1

meson: Allow C++/C exception stack traversal under MSVC ABI #1

Merged
amyspark merged 1 commit from amyspark/fix-msvc-issues into blackmagic/meson 2023年08月20日 21:15:47 +02:00
amyspark commented 2023年08月20日 21:11:02 +02:00 (Migrated from github.com)
Copy link

This fixes the warning:

libusb.h(1882): warning C5039: 'libusb_fill_bulk_transfer': pointer or
reference to potentially throwing function passed to 'extern "C"'
function under -EHc. Undefined behavior may occur if this function
throws an exception.

Do note that an identical fix needs to be applied to consumers, currently Meson does not expose this.

This fixes the warning: > libusb.h(1882): warning C5039: 'libusb_fill_bulk_transfer': pointer or > reference to potentially throwing function passed to 'extern "C"' > function under -EHc. Undefined behavior may occur if this function > throws an exception. Do note that an identical fix needs to be applied to consumers, currently Meson does not expose this.
dragonmux left a comment
Copy link

LGTM, nice catch! Merging.

LGTM, nice catch! Merging.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/libusb!1
Reference in a new issue
blackmagic-debug/libusb
No description provided.
Delete branch "amyspark/fix-msvc-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?