5
3
Fork
You've already forked bmputil
2

Fix: Clippy and rustc warnings #79

Merged
esden merged 4 commits from fix/clippy-and-rustc-warnings into main 2026年03月27日 18:37:47 +01:00

In this PR we clean up and fix the Clippy and rustc warnings that were being generated. This brings the build back to 100% clean and should also mean cargo clippy produces a clean result too - though this has only been checked on fruity OS so it's possible more things might be found if run on Windows or Linux after this is merged.

This is preparation for trying to crank the handle on a new release of this tool ready for BMPv3, and portal.

In this PR we clean up and fix the Clippy and rustc warnings that were being generated. This brings the build back to 100% clean and should also mean `cargo clippy` produces a clean result too - though this has only been checked on fruity OS so it's possible more things might be found if run on Windows or Linux after this is merged. This is preparation for trying to crank the handle on a new release of this tool ready for BMPv3, and portal.
metadata/firmware_download: Cleaned up the unit tests by swapping some assert-false invocations to using panic directly as this is what that does under the hood anyway
All checks were successful
ci/woodpecker/pr/build-windows/2 Pipeline was successful
ci/woodpecker/pr/build-linux Pipeline was successful
ci/woodpecker/pr/build-windows/1 Pipeline was successful
ci/woodpecker/push/build-linux Pipeline was successful
ci/woodpecker/push/build-windows/2 Pipeline was successful
ci/woodpecker/push/build-windows/1 Pipeline was successful
2d90592af0
esden left a comment
Copy link

LGTM

LGTM
esden deleted branch fix/clippy-and-rustc-warnings 2026年03月27日 18:37:47 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/bmputil!79
Reference in a new issue
blackmagic-debug/bmputil
No description provided.
Delete branch "fix/clippy-and-rustc-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?