5
3
Fork
You've already forked bmputil
2

Fix/bunch of lints #63

Merged
esden merged 3 commits from fix/bunch-of-lints into main 2025年09月12日 01:45:39 +02:00
esden commented 2025年09月11日 21:01:56 +02:00 (Migrated from github.com)
Copy link

This PR should address the outstanding new rust release warnings, some clippy lints and the dependabot alerts.

This also addresses the warnings reported in #60

This PR should address the outstanding new rust release warnings, some clippy lints and the dependabot alerts. This also addresses the warnings reported in #60
semanticdiff-com[bot] commented 2025年09月11日 21:01:58 +02:00 (Migrated from github.com)
Copy link

Review changes with SemanticDiff

Changed Files
File Status
src/bmp.rs 25% smaller
src/serial/remote/protocol_v1.rs 25% smaller
src/serial/remote/protocol_v2.rs 25% smaller
src/firmware_selector.rs 24% smaller
Cargo.lock Unsupported file format
Review changes with &nbsp;<a href="https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes"><picture><source media="(prefers-color-scheme: dark)" srcset="https://app.semanticdiff.com/images/github_button.svg?theme=dark&smaller=24"><source media="(prefers-color-scheme: light)" srcset="https://app.semanticdiff.com/images/github_button.svg?theme=light&smaller=24"><img src="https://app.semanticdiff.com/images/github_button.svg?theme=light&smaller=24" align="center" alt="SemanticDiff"></picture></a> <details> <summary>Changed Files</summary> <br/> | File | Status | | :--- | :--- | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/bmp.rs)&nbsp;&nbsp;[src/bmp\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/bmp.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=25">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/bmp.rs) &nbsp;25% smaller | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/serial/remote/protocol_v1.rs)&nbsp;&nbsp;[src/serial/remote/protocol\_v1\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/serial/remote/protocol_v1.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=25">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/serial/remote/protocol_v1.rs) &nbsp;25% smaller | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/serial/remote/protocol_v2.rs)&nbsp;&nbsp;[src/serial/remote/protocol\_v2\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/serial/remote/protocol_v2.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=25">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/serial/remote/protocol_v2.rs) &nbsp;25% smaller | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/firmware_selector.rs)&nbsp;&nbsp;[src/firmware\_selector\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/firmware_selector.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=24">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#src/firmware_selector.rs) &nbsp;24% smaller | | [<img src="https://app.semanticdiff.com/static/file-icons/settings.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#Cargo.lock)&nbsp;&nbsp;[Cargo\.lock](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/63/changes#Cargo.lock) | Unsupported file format | </details>
dragonmux left a comment
Copy link

LGTM, merging. Thank you for the contribution and sorting these items out!

LGTM, merging. Thank you for the contribution and sorting these items out!
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/bmputil!63
Reference in a new issue
blackmagic-debug/bmputil
No description provided.
Delete branch "fix/bunch-of-lints"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?