5
3
Fork
You've already forked bmputil
2

Fix: Linux protocol fault suppression #61

Merged
esden merged 2 commits from fix/linux-protocol-fault-suppression into main 2025年09月11日 05:19:34 +02:00

In this PR we address #56 and #60, by properly suppressing the protocol fault errors being generated under Linux on some machines when issuing DFU_DETACH packets.

We also take the opportunity to include the OS the user is running in the crash reports, as this information was missed from the initial crash report generator.

Fixes #56
Fixes #60

In this PR we address #56 and #60, by properly suppressing the protocol fault errors being generated under Linux on some machines when issuing DFU_DETACH packets. We also take the opportunity to include the OS the user is running in the crash reports, as this information was missed from the initial crash report generator. Fixes #56 Fixes #60
semanticdiff-com[bot] commented 2025年09月11日 03:10:20 +02:00 (Migrated from github.com)
Copy link

Review changes with SemanticDiff

Changed Files
File Status
src/bin/bmputil-cli.rs 81% smaller
src/bmp.rs 0% smaller
Review changes with &nbsp;<a href="https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes"><picture><source media="(prefers-color-scheme: dark)" srcset="https://app.semanticdiff.com/images/github_button.svg?theme=dark&smaller=49"><source media="(prefers-color-scheme: light)" srcset="https://app.semanticdiff.com/images/github_button.svg?theme=light&smaller=49"><img src="https://app.semanticdiff.com/images/github_button.svg?theme=light&smaller=49" align="center" alt="SemanticDiff"></picture></a> <details> <summary>Changed Files</summary> <br/> | File | Status | | :--- | :--- | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes#src/bin/bmputil-cli.rs)&nbsp;&nbsp;[src/bin/bmputil\-cli\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes#src/bin/bmputil-cli.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=81">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes#src/bin/bmputil-cli.rs) &nbsp;81% smaller | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes#src/bmp.rs)&nbsp;&nbsp;[src/bmp\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes#src/bmp.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=0">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/61/changes#src/bmp.rs) &nbsp;0% smaller | </details>
esden (Migrated from github.com) approved these changes 2025年09月11日 05:19:06 +02:00
esden (Migrated from github.com) left a comment
Copy link

LGTM

LGTM
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/bmputil!61
Reference in a new issue
blackmagic-debug/bmputil
No description provided.
Delete branch "fix/linux-protocol-fault-suppression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?