Tests for matching DeviceInfo #51

P-Storm commented 2025年07月17日 00:02:53 +02:00 (Migrated from github.com)

The testing of probe logic I have isolated, and now is in a unit test. It tests if the search filter has 'serial number', 'index' and 'port' matching.

I have implemented this in a Static Dispatch way, because DeviceInfo is not mockable.

A small debate is if MatchInformation should return the result of a match -> bool, or a property to match on. I think the property one is for now the best option, but open for oppinions

The testing of probe logic I have isolated, and now is in a unit test. It tests if the search filter has 'serial number', 'index' and 'port' matching. I have implemented this in a Static Dispatch way, because `DeviceInfo` is not mockable. A small debate is if `MatchInformation` should return the result of a match `-> bool`, or a property to match on. I think the property one is for now the best option, but open for oppinions

semanticdiff-com[bot] commented 2025年07月17日 00:02:55 +02:00 (Migrated from github.com)

Review changes with SemanticDiff

Changed Files

File	Status
src/bmp_matcher.rs	7% smaller
src/usb.rs	0% smaller

Review changes with &nbsp;<a href="https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes"><picture><source media="(prefers-color-scheme: dark)" srcset="https://app.semanticdiff.com/images/github_button.svg?theme=dark&smaller=7"><source media="(prefers-color-scheme: light)" srcset="https://app.semanticdiff.com/images/github_button.svg?theme=light&smaller=7"><img src="https://app.semanticdiff.com/images/github_button.svg?theme=light&smaller=7" align="center" alt="SemanticDiff"></picture></a> <details> <summary>Changed Files</summary> <br/> | File | Status | | :--- | :--- | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes#src/bmp_matcher.rs)&nbsp;&nbsp;[src/bmp\_matcher\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes#src/bmp_matcher.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=7">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes#src/bmp_matcher.rs) &nbsp;7% smaller | | [<img src="https://app.semanticdiff.com/static/file-icons/rust.svg" width="20" height="20" align="center">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes#src/usb.rs)&nbsp;&nbsp;[src/usb\.rs](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes#src/usb.rs) | [<img src="https://app.semanticdiff.com/images/progressbar.svg?progress=0">](https://app.semanticdiff.com/gh/blackmagic-debug/bmputil/pull/51/changes#src/usb.rs) &nbsp;0% smaller | </details>

This pull request has changes conflicting with the target branch.