7
31
Fork
You've already forked blackmagic
23

bmda: Add TCP_NODELAY option to socket connections to disable Nagle's algorithm and reduce latency. #2289

Merged
dragonmux merged 1 commit from sidprice/blackmagic:feature/bmda-remote-comms into feature/bmda-remote-comms 2026年07月08日 00:25:50 +02:00
Contributor
Copy link

The option TCP_NODELAY when applied to a socket disables Nagle's Algorithm. This reduces latency when small packets are trasnfered over the network

Your checklist for this pull request

Note: This has not been tested on Linux/Mac platforms.

The option TCP_NODELAY when applied to a socket disables Nagle's Algorithm. This reduces latency when small packets are trasnfered over the network ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do Note: This has not been tested on Linux/Mac platforms.
bmda: Add TCP_NODELAY option to socket connections to disable Nagle's algorithm and reduce latency.
Some checks failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline failed
ci/woodpecker/pr/build-windows Pipeline failed
ci/woodpecker/pr/lint Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
c8f3c2a70c
dragonmux requested changes 2026年07月07日 21:39:17 +02:00
Dismissed
dragonmux left a comment
Copy link

Only have the one review note (which applies to the POSIX result of setsockopt() too) but with that addressed, this looks good to us.

Only have the one review note (which applies to the POSIX result of `setsockopt()` too) but with that addressed, this looks good to us.
@ -105,2 +109,3 @@
}
if (connect(fd, server_addr->ai_addr, server_addr->ai_addrlen) == -1) {
if (connect(fd, server_addr->ai_addr, server_addr->ai_addrlen) == SOCKET_ERROR) {

Per https://linux.die.net/man/3/connect and other man pages on connect(), checking for -1 here explicitly is correct - unsure if SOCKET_ERROR exists on not-Windows

Per `https://linux.die.net/man/3/connect` and other man pages on `connect()`, checking for `-1` here explicitly is correct - unsure if `SOCKET_ERROR` exists on not-Windows
dragonmux marked this conversation as resolved
sidprice force-pushed feature/bmda-remote-comms from c8f3c2a70c
Some checks failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline failed
ci/woodpecker/pr/build-windows Pipeline failed
ci/woodpecker/pr/lint Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
to 8a904f58c3
Some checks failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
2026年07月07日 22:25:26 +02:00
Compare
dragonmux approved these changes 2026年07月07日 22:33:04 +02:00
Dismissed
dragonmux left a comment
Copy link

LGTM, we'll get this merged once CI completes. Thank you for the contribution!

LGTM, we'll get this merged once CI completes. Thank you for the contribution!
sidprice force-pushed feature/bmda-remote-comms from 8a904f58c3
Some checks failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
to 3871431045
Some checks failed
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
2026年07月07日 22:46:14 +02:00
Compare
sidprice force-pushed feature/bmda-remote-comms from 3871431045
Some checks failed
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
to a8fbcd008d
All checks were successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
2026年07月07日 23:31:30 +02:00
Compare
dragonmux merged commit a8fbcd008d into feature/bmda-remote-comms 2026年07月08日 00:25:50 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2289
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "sidprice/blackmagic:feature/bmda-remote-comms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?