7
31
Fork
You've already forked blackmagic
23

feature/tm4c129xnczad #2282

Open
rbsexton wants to merge 2 commits from rbsexton/blackmagic:feature/tm4c129xnczad into main
pull from: rbsexton/blackmagic:feature/tm4c129xnczad
merge into: blackmagic-debug:main
blackmagic-debug:main
blackmagic-debug:feature/bmda-remote-comms
blackmagic-debug:ALTracer/feature/aarch64-ident
blackmagic-debug:feature/better-meson-optimisation-handling
blackmagic-debug:feature/am335x-support
blackmagic-debug:feature/esp32-c3-support
blackmagic-debug:feature/cortex-ar-software-breakpoints
blackmagic-debug:feature/unit-testing
blackmagic-debug:feature/windows-usb-serial-interface-naming
blackmagic-debug:fix/bmp-external-spi
blackmagic-debug:ALTracer/feature/bluepillplus-platform
blackmagic-debug:ALTracer/feature/at32f43x-unrdp
blackmagic-debug:feature/const-correctness
blackmagic-debug:ALTracer/feature/fault_handlers
blackmagic-debug:ALTracer/feature/hazard3-ice40-support
blackmagic-debug:fix/ci-cleanup
blackmagic-debug:ALTracer/fix/gdb-10-12-thread
blackmagic-debug:ALTracer/feature/blackpill-f4-adc
blackmagic-debug:ALTracer/fix/cortex-desc-allocfail-report
blackmagic-debug:ALTracer/feature/spi-perf
blackmagic-debug:ALTracer/feature/calibrate_swd
blackmagic-debug:ALTracer/feature/blank-check
blackmagic-debug:feature/avr
blackmagic-debug:v2.0
blackmagic-debug:v1.9
blackmagic-debug:v1.10
blackmagic-debug:v1.8
First-time contributor
Copy link

Add Support for the TI tm4c129xnczad

  • Convert the existing code from probe functions with case statements to a lookup table.
  • Add Block/Erase size to the lookup table to support the larger erase size on Snowflake class devices.
  • Add a fixed constant LMI_FLASH_WRITESIZE to limit writes to match write size.
  • Document a discrepancy between the flash stub and the data sheet.
  • Tested extensively against a tm4c129xnczad.

Your checklist for this pull request

Closing issues

## Add Support for the TI tm4c129xnczad - Convert the existing code from probe functions with case statements to a lookup table. - Add Block/Erase size to the lookup table to support the larger erase size on Snowflake class devices. - Add a fixed constant LMI_FLASH_WRITESIZE to limit writes to match write size. - Document a discrepancy between the flash stub and the data sheet. - Tested extensively against a tm4c129xnczad. ## Your checklist for this pull request * [X] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md) * [X] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository * [X] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware)) * [X] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [X] I've tested it to the best of my ability * [X] My commit messages provide a useful short description of what the commits do ## Closing issues <!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->
Convert the existing probe code to a data table for device parameters.
Remove the lm3/tm4c probe functions that use case statements and replace them with a table lookup
Snowflake-class devices have a larger block size.
Remove the hard-wired LMI_BLOCK_SIZE constant and put the block size into the table.
Document a discrepancy between the known good LMI flash stub and the TI data sheet.
Some checks failed
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
ede509a781
dragonmux requested changes 2026年07月01日 09:42:03 +02:00
Dismissed
dragonmux left a comment
Copy link

This is generally looking good - there are some stylistic things to address, and please take a look in the contrib guidelines for how to prefix your commit messages in line with the codebase style.

With those sorted though, and if this appears to be working properly for your part(s) when tested, we'll test the TM4C123GH6PM sat on our desk with this with the aim to get it merged in the v2.2 merge window. We don't see any reasons this shouldn't work though.

This is generally looking good - there are some stylistic things to address, and please take a look in the contrib guidelines for how to prefix your commit messages in line with the codebase style. With those sorted though, and if this appears to be working properly for your part(s) when tested, we'll test the TM4C123GH6PM sat on our desk with this with the aim to get it merged in the v2.2 merge window. We don't see any reasons this shouldn't work though.
@ -34,0 +37,4 @@
Existing stub with FMA before FMD is known to work.
June 2026

No need to date this.. we don't do that in this code base.. Please use the codebase

/*
 * Multi-line
 * block
 *
 * comment
 * format
 */

for this comment.

No need to date this.. we don't do that in this code base.. Please use the codebase ```c /* * Multi-line * block * * comment * format */ ``` for this comment.
dragonmux marked this conversation as resolved
src/target/lmi.c Outdated
@ -30,1 +30,4 @@
* * TM4C129XNCZAD Datasheet (https://www.ti.com/lit/gpn/tm4c129xnczad)
* * LM3S3748 Datasheet (https://www.ti.com/lit/ds/symlink/lm3s3748.pdf)
*
* Change History

We don't do change histories like this - please remove this. That is what git is for.

We don't do change histories like this - please remove this. That is what `git` is for.
dragonmux marked this conversation as resolved
src/target/lmi.c Outdated
@ -102,1 +116,4 @@
// The erase size can be very large. The maximum
// write size is limited by the memory in the probe.
#define LMI_FLASH_WRITESIZE 0x400

Please suffix this constant with a U so it is inherently unsigned and doesn't go through implicit conversion on use.

Please suffix this constant with a `U` so it is inherently unsigned and doesn't go through implicit conversion on use.
dragonmux marked this conversation as resolved
src/target/lmi.c Outdated
@ -104,3 +122,4 @@
#include "flashstub/lmi.stub"
};
typedef struct {

Please name the structure - lmi_device per the typedef name below (which is itself correct)

Please name the structure - `lmi_device` per the typedef name below (which is itself correct)
dragonmux marked this conversation as resolved
src/target/lmi.c Outdated
@ -107,0 +129,4 @@
uint32_t block_size;
const char *driver;
uint32_t target_options;
uint32_t dp_quirks;

The DP quirks are a uint8_t in the ADIv5 structures, so no need for this to be a u32 - might as well save Flash by narrowing it. Similarly the RAM and Flash sizes look like they're all multiples of 1KiB that if divided down might well fit in a uint16_t, so might as well be optimised this way to reduce Flash usage.

Please include all leading 0's in the hex constants below - not including them makes it much harder to gauge magnitude and not misread by miscounting.

The DP quirks are a `uint8_t` in the ADIv5 structures, so no need for this to be a u32 - might as well save Flash by narrowing it. Similarly the RAM and Flash sizes look like they're all multiples of 1KiB that if divided down might well fit in a `uint16_t`, so might as well be optimised this way to reduce Flash usage. Please include all leading 0's in the hex constants below - not including them makes it much harder to gauge magnitude and not misread by miscounting.
Author
First-time contributor
Copy link

I was wondering the same thing. The probe flash is pretty small. I tried using JEDEC-style encoding for the sizes, but theres a 96k device in the table, so thats not going to work in an obvious/simple way. Encode as K works pretty well and it's inspect.

I was wondering the same thing. The probe flash is pretty small. I tried using JEDEC-style encoding for the sizes, but theres a 96k device in the table, so thats not going to work in an obvious/simple way. Encode as K works pretty well and it's inspect.
dragonmux marked this conversation as resolved
src/target/lmi.c Outdated
@ -196,1 +184,4 @@
}
// Iterate over the device list. If we find a match, return true.
for (size_t i = 0; i < ARRAY_LENGTH(lmi_devices); ++i) {

Please suffix the 0 with a U so it's an unsigned initialisation of an unsigned value.

Please suffix the `0` with a `U` so it's an unsigned initialisation of an unsigned value.
dragonmux marked this conversation as resolved
Author
First-time contributor
Copy link

I've made up a new branch with all of the requested changes and better commit messages. Should I submit a new MR or add additional commits to this one?

I've made up a new branch with all of the requested changes and better commit messages. Should I submit a new MR or add additional commits to this one?
Author
First-time contributor
Copy link

Also: Would you like additional hardware for your test environment? I've got a box of eval boards for the popular network connected devices from LMI and Tiva, including the lm3s6965 thats the reference design for Qemu.

Also: Would you like additional hardware for your test environment? I've got a box of eval boards for the popular network connected devices from LMI and Tiva, including the lm3s6965 thats the reference design for Qemu.

@rbsexton wrote in #2282 (comment):

I've made up a new branch with all of the requested changes and better commit messages. Should I submit a new MR or add additional commits to this one?

You should rebase this branch, which will update the request with the changes etc.. No idea how you were taught to use Git for your job, but in the broad sense the only time git rebase-based rewriting of history is "forbidden" is on the main branch of a repo.. a branch of a fork repo that you're preparing a changeset on to submit to a main repo, can absolutely be rebased however much you need/like and never violate that rule. Thus, git rebase -i main to also correct commit messages, and such.. git cherry-pick to pull fixes from that other branch onto this one as needed. Completely acceptable to do.

That also pairs with git push -f for this task, as force-pushing a PR branch is not only acceptable but encouraged.

@rbsexton wrote in https://codeberg.org/blackmagic-debug/blackmagic/pulls/2282#issuecomment-18395207: > I've made up a new branch with all of the requested changes and better commit messages. Should I submit a new MR or add additional commits to this one? You should rebase this branch, which will update the request with the changes etc.. No idea how you were taught to use Git for your job, but in the broad sense the only time `git rebase`-based rewriting of history is "forbidden" is on the main branch of a repo.. a branch of a fork repo that you're preparing a changeset on to submit to a main repo, can absolutely be rebased however much you need/like and never violate that rule. Thus, `git rebase -i main` to also correct commit messages, and such.. `git cherry-pick` to pull fixes from that other branch onto this one as needed. Completely acceptable to do. That also pairs with `git push -f` for this task, as force-pushing a PR branch is not only acceptable but encouraged.
rbsexton closed this pull request 2026年07月02日 01:57:28 +02:00
Author
First-time contributor
Copy link

I'm in change of a very small team that doesn't use a web-mediated MR process. This is mostly new to me.

Thanks very much for explaining that.

I'm in change of a very small team that doesn't use a web-mediated MR process. This is mostly new to me. Thanks very much for explaining that.
rbsexton reopened this pull request 2026年07月02日 02:19:36 +02:00
rbsexton force-pushed feature/tm4c129xnczad from 9e48e42d47
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
to a2b8b16c9f
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
2026年07月02日 02:23:31 +02:00
Compare
Author
First-time contributor
Copy link

All changes have been rolled up and commit messages are cleaned up.

All changes have been rolled up and commit messages are cleaned up.
rbsexton changed title from (削除) WIP: feature/tm4c129xnczad (削除ここまで) to feature/tm4c129xnczad 2026年07月02日 02:29:08 +02:00
dragonmux approved these changes 2026年07月02日 13:33:59 +02:00
Dismissed
dragonmux left a comment
Copy link

Other than the one date that's still floating about, this all looks good now - we'll aim to ask you to rebase this when the v2.2 merge window opens so we can then get it merged then. Thank you for the contribution!

Other than the one date that's still floating about, this all looks good now - we'll aim to ask you to rebase this when the v2.2 merge window opens so we can then get it merged then. Thank you for the contribution!
@ -34,0 +36,4 @@
* specify write FMD, write FMA, then trigger via FMC
*
* Existing stub with FMA before FMD is known to work.
* June 2026

This date can and should be dropped please.

This date can and should be dropped please.
dragonmux marked this conversation as resolved
rbsexton force-pushed feature/tm4c129xnczad from a2b8b16c9f
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
to 47a85ed4ab
Some checks failed
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
2026年07月02日 16:51:55 +02:00
Compare
rbsexton dismissed dragonmux's review 2026年07月02日 16:51:55 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dragonmux approved these changes 2026年07月02日 16:55:12 +02:00
Dismissed
rbsexton force-pushed feature/tm4c129xnczad from 47a85ed4ab
Some checks failed
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline failed
to c6dd5292b9
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
2026年07月02日 18:06:12 +02:00
Compare
rbsexton dismissed dragonmux's review 2026年07月02日 18:06:12 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Author
First-time contributor
Copy link

Clang-fixes.

Disabled clang-format for vertically aligned tables and #defines. Added spaces around << per clang-format.

Clang-fixes. Disabled clang-format for vertically aligned tables and #defines. Added spaces around << per clang-format.
rbsexton force-pushed feature/tm4c129xnczad from c6dd5292b9
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
to d42178a659
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
2026年07月02日 18:15:30 +02:00
Compare
Author
First-time contributor
Copy link

Run it all through clang-format to fix some line ending issues.

Run it all through clang-format to fix some line ending issues.
src/target/lmi.c Outdated
@ -107,0 +126,4 @@
uint8_t dp_quirks;
} lmi_device_s;
/* clang-format off */

In this case, please don't fight clang-format to align these tables, the way it wants to reformat them makes this match similar tables in other support. The only places we turn it off for a table is where it makes a complete mess of that table, in some very limited spots in architecture support.

In this case, please don't fight `clang-format` to align these tables, the way it wants to reformat them makes this match similar tables in other support. The only places we turn it off for a table is where it makes a complete mess of that table, in some very limited spots in architecture support.
rbsexton force-pushed feature/tm4c129xnczad from d42178a659
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
to 068c318ec9
All checks were successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
2026年07月03日 15:58:23 +02:00
Compare
Author
First-time contributor
Copy link

Done.

Done.
dragonmux left a comment
Copy link

LGTM, merging when the v2.2 merge window opens. Thank you for the contribution!

(We'll ask you to rebase when we go to do this)

LGTM, merging when the v2.2 merge window opens. Thank you for the contribution! (We'll ask you to rebase when we go to do this)
All checks were successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
Required
Details
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/8 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
Required
Details
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
Required
Details
ci/woodpecker/pr/lint Pipeline was successful
Required
Details
This pull request is blocked because it's outdated.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/tm4c129xnczad:rbsexton-feature/tm4c129xnczad
git switch rbsexton-feature/tm4c129xnczad
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2282
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "rbsexton/blackmagic:feature/tm4c129xnczad"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?