7
31
Fork
You've already forked blackmagic
23

Feature: report the count of Cortex-M breakpoint, watchpoint slots on attach #2261

Merged
dragonmux merged 1 commit from ALTracer/blackmagic:feature/cortexm-log-breakpoint-count into main 2026年05月23日 06:45:28 +02:00
Contributor
Copy link

Detailed description

  • This is a small new feature, existing code from cortexar.c
  • The problem is Cortex-A/R Breakpoint Unit count is reported in logs but Cortex-M FPB (or BPU) slot count is not (and DWT). Other debug servers print them.
  • This PR solves it by copying a couple lines from cortexar.c into cortexm.c

This is an old patch of mine from almost two years ago, related to some hardware breakpoint funkiness on STM32F411 DUT, then fixed by PR2010 or something. I still believe it is beneficial to report whether the processor core (which BMP attaches to) happens to offer 4, 6 or 8 hardware breakpoint slots. Even riscv_debug.c:riscv_hart_discover_triggers() does it.
Tested on BMDA, example -tv 5 output is

*** 1 AT32F403A/407 M4
Attaching to target..
Halting target
Target halted: Halt requested
AT32F403A/407 M4 core has 6 breakpoint and 4 watchpoint slots available
Attach success

Your checklist for this pull request

Closing issues

## Detailed description * This is a small new feature, existing code from cortexar.c * The problem is Cortex-A/R Breakpoint Unit count is reported in logs but Cortex-M FPB (or BPU) slot count is not (and DWT). Other debug servers print them. * This PR solves it by copying a couple lines from cortexar.c into cortexm.c This is an old patch of mine from almost two years ago, related to some hardware breakpoint funkiness on STM32F411 DUT, then fixed by PR2010 or something. I still believe it is beneficial to report whether the processor core (which BMP attaches to) happens to offer 4, 6 or 8 hardware breakpoint slots. Even `riscv_debug.c:riscv_hart_discover_triggers()` does it. Tested on BMDA, example -tv 5 output is ``` *** 1 AT32F403A/407 M4 Attaching to target.. Halting target Target halted: Halt requested AT32F403A/407 M4 core has 6 breakpoint and 4 watchpoint slots available Attach success ``` ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues
cortexm: Report the count of breakpoint, watchpoint slots on attach
Some checks failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/push/build-firmware/8 Pipeline failed
ci/woodpecker/push/build-firmware/6 Pipeline was successful
ci/woodpecker/push/build-firmware/1 Pipeline was successful
ci/woodpecker/push/build-firmware/4 Pipeline was successful
ci/woodpecker/push/build-firmware/3 Pipeline was successful
ci/woodpecker/push/build-firmware/2 Pipeline was successful
ci/woodpecker/push/build-firmware/7 Pipeline was successful
ci/woodpecker/push/build-firmware/5 Pipeline was successful
ci/woodpecker/push/build-firmware/11 Pipeline was successful
ci/woodpecker/push/build-firmware/10 Pipeline was successful
ci/woodpecker/push/build-firmware/9 Pipeline was successful
ci/woodpecker/push/build-firmware/13 Pipeline failed
ci/woodpecker/push/build-firmware/14 Pipeline was successful
ci/woodpecker/push/build-firmware/12 Pipeline was successful
ci/woodpecker/push/build-firmware/15 Pipeline was successful
ci/woodpecker/push/build-firmware/16 Pipeline was successful
ci/woodpecker/push/build-firmware/19 Pipeline was successful
ci/woodpecker/push/build-firmware/18 Pipeline failed
ci/woodpecker/push/build-firmware/17 Pipeline was successful
ci/woodpecker/push/build-linux/1 Pipeline was successful
ci/woodpecker/push/build-firmware/20 Pipeline was successful
ci/woodpecker/push/build-linux/2 Pipeline was successful
ci/woodpecker/push/build-windows Pipeline was successful
6a59fb2b0b
dragonmux left a comment
Copy link

LGTM, merging once CI completes. Thank you for this contribution that makes the Cortex support a bit more consistent between -A/R and -M!

LGTM, merging once CI completes. Thank you for this contribution that makes the Cortex support a bit more consistent between -A/R and -M!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2261
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "ALTracer/blackmagic:feature/cortexm-log-breakpoint-count"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?