8
33
Fork
You've already forked blackmagic
23

Feature: catch the JTAG-DP exception from Cortex-M reset-by-AIRCR #2260

Merged
dragonmux merged 1 commit from ALTracer/blackmagic:feature/cortexm-aircr-jtag into main 2026年06月13日 18:36:12 +02:00
Contributor
Copy link

Detailed description

  • This is a small new feature. See #2248 (comment)
  • The existing problem is AT32F403A flashing fails when connected via 4-wire JTAG transport without physical reset wire: JTAG-DP invalid ACK.
  • This PR solves it by catching that exception.

Tested on blackpill-f411ce against AT32F403ACGU7 as found on https://github.com/WeActStudio/WeActStudio.BlackPill , and on BMDA (I think). I have not seen a similar error (refuse to reset/flash) with other targets or probe platforms, if only J-Link. JTAG access resulted in 0:0 messages can still appear on DEBUG_TARGET channel of BMF. If the comment block is unwelcome, then I'll delete it in favor of Codeberg/Forgejo issue trackers.
Related, let's drop the extraneous 10ms delay I introduced back in PR2072. It didn't exist there, and there are two other 10ms delays around it (one after 1ms RST pulse, one near return from cortexm_reset()).

Your checklist for this pull request

Closing issues

## Detailed description * This is a small new feature. See https://codeberg.org/blackmagic-debug/blackmagic/pulls/2248#issuecomment-14374226 * The existing problem is AT32F403A flashing fails when connected via 4-wire JTAG transport without physical reset wire: `JTAG-DP invalid ACK`. * This PR solves it by catching that exception. Tested on `blackpill-f411ce` against AT32F403ACGU7 as found on https://github.com/WeActStudio/WeActStudio.BlackPill , and on BMDA (I think). I have not seen a similar error (refuse to reset/flash) with other targets or probe platforms, if only J-Link. `JTAG access resulted in 0:0` messages can still appear on DEBUG_TARGET channel of BMF. If the comment block is unwelcome, then I'll delete it in favor of Codeberg/Forgejo issue trackers. Related, let's drop the extraneous 10ms delay I introduced back in PR2072. It didn't exist there, and there are two other 10ms delays around it (one after 1ms RST pulse, one near return from `cortexm_reset()`). ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues
dragonmux approved these changes 2026年05月23日 06:53:36 +02:00
Dismissed
dragonmux left a comment
Copy link

Looks reasonable save for the one issue, merging once rebased on main and CI completes. Thank you for this contribution that fixes how reset complete on certain parts!

Looks reasonable save for the one issue, merging once rebased on `main` and CI completes. Thank you for this contribution that fixes how reset complete on certain parts!
@ -779,0 +795,4 @@
dp->ensure_idle(dp);
break;
}
}

Surely the 10ms delay is still needed after this? so the target has time to assert and de-assert reset? otherwise surely we should be checking if the AIRCR reset request bit has cleared before we assume it's all okay..

Surely the 10ms delay is still needed after this? so the target has time to assert and de-assert reset? otherwise surely we should be checking if the AIRCR reset request bit has cleared before we assume it's all okay..
Author
Contributor
Copy link

No. This middle 10ms delay was added to me "just in case", looking at reset-by-wire. Target asserts its NRST pin after 8 SWD idle clocks, and deasserts "immediately" (clock is some internal 40 kHz or 8 MHz, or full async), with an open-drain driver, and the typ. 40 kOhm pull-up raises it above 2.0v V_IH after a few milliseconds, but that's not important because most Cortex-M support "connect under reset" anyways. Practically in SWD transport I've seen no errors for this one chip.
AIRCR request bit is write-only, can't check that; but DHCSR->S_RESET_ST will get set, and that is already checked by the loop a few lines later.

No. This middle 10ms delay was added to me "just in case", looking at reset-by-wire. Target asserts its NRST pin after 8 SWD idle clocks, and deasserts "immediately" (clock is some internal 40 kHz or 8 MHz, or full async), with an open-drain driver, and the typ. 40 kOhm pull-up raises it above 2.0v V_IH after a few milliseconds, but that's not important because most Cortex-M support "connect under reset" anyways. Practically in SWD transport I've seen no errors for this one chip. AIRCR request bit is write-only, can't check that; but DHCSR->S_RESET_ST will get set, and that is already checked by the loop a few lines later.
dragonmux marked this conversation as resolved
ALTracer force-pushed feature/cortexm-aircr-jtag from 2d02f48b39
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
ci/woodpecker/pr/lint Pipeline is pending approval
to ed9de3aad8
Some checks failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
2026年05月24日 21:48:59 +02:00
Compare
ALTracer dismissed dragonmux's review 2026年05月24日 21:48:59 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dragonmux left a comment
Copy link

LGTM, merging once CI completes. Thank you for the contribution!

LGTM, merging once CI completes. Thank you for the contribution!
ALTracer force-pushed feature/cortexm-aircr-jtag from ed9de3aad8
Some checks failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline was successful
ci/woodpecker/pr/build-firmware/3 Pipeline was successful
ci/woodpecker/pr/build-firmware/5 Pipeline was successful
ci/woodpecker/pr/build-firmware/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/4 Pipeline was successful
ci/woodpecker/pr/build-firmware/6 Pipeline was successful
ci/woodpecker/pr/build-firmware/2 Pipeline was successful
ci/woodpecker/pr/build-firmware/9 Pipeline was successful
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline was successful
ci/woodpecker/pr/build-firmware/14 Pipeline was successful
ci/woodpecker/pr/build-firmware/12 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/15 Pipeline was successful
ci/woodpecker/pr/build-firmware/10 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
to bf757c8b8d
Some checks failed
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/pr/lint Pipeline was successful
ci/woodpecker/push/build-firmware/3 Pipeline was successful
ci/woodpecker/push/build-firmware/5 Pipeline was successful
ci/woodpecker/push/build-firmware/2 Pipeline was successful
ci/woodpecker/push/build-firmware/6 Pipeline was successful
ci/woodpecker/push/build-firmware/1 Pipeline was successful
ci/woodpecker/push/build-firmware/4 Pipeline was successful
ci/woodpecker/push/build-firmware/7 Pipeline was successful
ci/woodpecker/push/build-firmware/8 Pipeline failed
ci/woodpecker/push/build-firmware/9 Pipeline was successful
ci/woodpecker/push/build-firmware/13 Pipeline failed
ci/woodpecker/push/build-firmware/12 Pipeline was successful
ci/woodpecker/push/build-firmware/11 Pipeline was successful
ci/woodpecker/push/build-firmware/10 Pipeline was successful
ci/woodpecker/push/build-firmware/14 Pipeline was successful
ci/woodpecker/push/build-firmware/15 Pipeline was successful
ci/woodpecker/push/build-firmware/20 Pipeline was successful
ci/woodpecker/push/build-firmware/17 Pipeline was successful
ci/woodpecker/push/build-firmware/18 Pipeline was successful
ci/woodpecker/push/build-firmware/19 Pipeline was successful
ci/woodpecker/push/build-firmware/16 Pipeline was successful
ci/woodpecker/push/build-linux/1 Pipeline was successful
ci/woodpecker/push/build-linux/2 Pipeline was successful
ci/woodpecker/push/build-windows Pipeline was successful
2026年06月13日 18:18:51 +02:00
Compare
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2260
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "ALTracer/blackmagic:feature/cortexm-aircr-jtag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?