Fix: detect onboard flash NOR chips other than Winbond (on other platforms) #2217

ALTracer commented 2026年03月24日 19:47:22 +01:00

Detailed description

• This is not a new feature.
• The existing problem is BMF logic expecting Winbond SPI Flash chips onboard the probe, which is only true for native.
• The PR solves it by allowing other Vendor chips in onboard_flash_add().

Tested on BluePill-Plus/STM32F103CB with Macronix MX25L32 SOIC-8 flash chip soldered.
I would prefer refactoring that check to only happen on native, to not have to carry a dictionary of JEDEC IDs in BMF with SPI support.
It shouldn't generally matter here which chip is soldered/picked, as long as it responds to 25-series protocol in SIO mode.

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (see Building the firmware)
• It builds as BMDA (see Building the BMDA)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

## Detailed description * This is not a new feature. * The existing problem is BMF logic expecting Winbond SPI Flash chips onboard the probe, which is only true for `native`. * The PR solves it by allowing other Vendor chips in onboard_flash_add(). Tested on BluePill-Plus/STM32F103CB with Macronix MX25L32 SOIC-8 flash chip soldered. I would prefer refactoring that check to only happen on `native`, to not have to carry a dictionary of JEDEC IDs in BMF with SPI support. It shouldn't generally matter here which chip is soldered/picked, as long as it responds to 25-series protocol in SIO mode. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues

dragonmux commented 2026年03月26日 18:32:01 +01:00

We would agree that making the check native-specific would be better - #ifdef'ing around the if block and providing instead only an ID validity check much like found in the i.MXRT or RP2040/2350 code would be much better we think for the generic version of this.

We would agree that making the check `native`-specific would be better - `#ifdef`'ing around the `if` block and providing instead only an ID validity check much like found in the i.MXRT or RP2040/2350 code would be much better we think for the generic version of this.

ALTracer commented 2026年03月27日 20:17:29 +01:00

@dragonmux wrote in #2217 (comment):

We would agree that making the check native-specific would be better - #ifdef'ing around the if block and providing instead only an ID validity check much like found in the i.MXRT or RP2040/2350 code would be much better we think for the generic version of this.

So I picked and inverted the check, such that any of three JEDEC ID bytes being 0xff trigger an error. Two minor problems, I can't seem to find a nice way to #ifdef around native/bmp-v3, and "25-series" is too vague.

@dragonmux wrote in https://codeberg.org/blackmagic-debug/blackmagic/pulls/2217#issuecomment-12174384: > We would agree that making the check `native`-specific would be better - `#ifdef`'ing around the `if` block and providing instead only an ID validity check much like found in the i.MXRT or RP2040/2350 code would be much better we think for the generic version of this. So I picked and inverted the check, such that any of three JEDEC ID bytes being 0xff trigger an error. Two minor problems, I can't seem to find a nice way to #ifdef around native/bmp-v3, and "25-series" is too vague.

dragonmux commented 2026年03月27日 20:30:28 +01:00

native is found by BLACKMAGIC being defined, and v3 by BLACKMAGICPROBE_V3 being defined - those are the only two platforms those are defined for.

`native` is found by `BLACKMAGIC` being defined, and v3 by `BLACKMAGICPROBE_V3` being defined - those are the only two platforms those are defined for.

ALTracer commented 2026年03月27日 21:21:30 +01:00

It now prints this where "Windbond" was:

(gdb) mon spi_scan
Available Targets:
No. Att Driver
 1 Onboard SPI Flash 25-series
(gdb) att 1
Attaching to Remote target
Truncated register 0 in remote 'g' packet
(gdb) info mem
Using memory regions provided by the target.
Num Enb Low Addr High Addr Attrs 
0 y 0x00000000 0x00400000 flash blocksize 0x1000 nocache

It now prints this where "Windbond" was: ``` (gdb) mon spi_scan Available Targets: No. Att Driver 1 Onboard SPI Flash 25-series (gdb) att 1 Attaching to Remote target Truncated register 0 in remote 'g' packet (gdb) info mem Using memory regions provided by the target. Num Enb Low Addr High Addr Attrs 0 y 0x00000000 0x00400000 flash blocksize 0x1000 nocache ```