Detailed description
In this PR we finish the conversion and cleanup from the loose buffer pointer + length used before, to the gdb_packet_s structure for all the remote protocol code and GDB packet code for consuming remote protocol packets. This finishes what was started by Perigoso in the v2.0 release.
Tested working against both a JTAG and SWD ADIv5 target using BMPv3. Changes are fairly mechanical in nature, thus we consider this sufficient to catch all the major possible issues.
Your checklist for this pull request
- I've read the Code of Conduct
- I've read the guidelines for contributing to this repository
- It builds for hardware native (see Building the firmware)
- It builds as BMDA (see Building the BMDA)
- I've tested it to the best of my ability
- My commit messages provide a useful short description of what the commits do
Closing issues
<!-- Filling this template is mandatory -->
## Detailed description
In this PR we finish the conversion and cleanup from the loose buffer pointer + length used before, to the gdb_packet_s structure for all the remote protocol code and GDB packet code for consuming remote protocol packets. This finishes what was started by Perigoso in the v2.0 release.
Tested working against both a JTAG and SWD ADIv5 target using BMPv3. Changes are fairly mechanical in nature, thus we consider this sufficient to catch all the major possible issues.
## Your checklist for this pull request
* [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md)
* [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository
* [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware))
* [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app))
* [x] I've tested it to the best of my ability
* [x] My commit messages provide a useful short description of what the commits do
## Closing issues
<!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->