7
31
Fork
You've already forked blackmagic
23

Cortex-M: poll halt state #2214

Merged
dragonmux merged 1 commit from mdrssv/blackmagic:cortexm-halt-poll into main 2026年03月23日 09:31:58 +01:00
Contributor
Copy link

Detailed description

Prior this patch attach to an NRF54L15 would fail the first time but succeed the second time probably because the halt takes a moment to become effective. The cortex-ar target already contained a fix for an presumably similar issue which I've copied into the cortex-m target. The probe will wait at most 250ms for the target to be haltet.

Your checklist for this pull request

Closing issues

Fixes #2155

<!-- Filling this template is mandatory --> ## Detailed description Prior this patch attach to an **NRF54L15** would fail the first time but succeed the second time probably because the halt takes a moment to become effective. The cortex-ar target already contained a fix for an presumably similar issue which I've copied into the cortex-m target. The probe will wait at most 250ms for the target to be haltet. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues Fixes #2155
mdrssv force-pushed cortexm-halt-poll from 292626a55d
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
to 907ae9d663
Some checks failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
2026年03月19日 15:23:43 +01:00
Compare
dragonmux left a comment
Copy link

There's only one thing we spotted - otherwise this looks reasonable. A thing of note for your commit message: per the contribution guidelines, the prefix for this should be cortexm: - this is the single file in the target area that you're changing thus is the prefix, unambiguously.

We would suggest something like cortexm: Fixed attach to repeatedly poll to check if halting completed for up to 250ms to account for slow targets - this conveys what changed, why, and surmises the change set.

A note on nomenclature, Cortex-M and Cortex-A/R support are not targets, but rather architectures. There are ongoing rumblings to improve the code organisation to make this more obvious and clear, but these haven't yet been executed on.

There's only one thing we spotted - otherwise this looks reasonable. A thing of note for your commit message: per the contribution guidelines, the prefix for this should be `cortexm: ` - this is the single file in the target area that you're changing thus is the prefix, unambiguously. We would suggest something like `cortexm: Fixed attach to repeatedly poll to check if halting completed for up to 250ms to account for slow targets` - this conveys what changed, why, and surmises the change set. A note on nomenclature, Cortex-M and Cortex-A/R support are not *targets*, but rather *architectures*. There are ongoing rumblings to improve the code organisation to make this more obvious and clear, but these haven't yet been executed on.
@ -523,10 +523,13 @@ bool cortexm_attach(target_s *target)
target_check_error(target);
/* Try to halt the core, and then check that it worked (which also resets the halt reason) */
target_halt_request(target);

Did you mean to remove the request line here? Not sure how this works without that as target_halt_poll() only checks to see if the halt's taken place, but cannot itself request it.

Did you mean to remove the request line here? Not sure how this works without that as `target_halt_poll()` only checks to see if the halt's taken place, but cannot itself request it.
Author
Contributor
Copy link

Good catch, must have gotten lost why copy & pasting from my other bmp checkout

Good catch, must have gotten lost why copy & pasting from my other bmp checkout
mdrssv marked this conversation as resolved
mdrssv force-pushed cortexm-halt-poll from 907ae9d663
Some checks failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
to 7a1a3e2e55
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
2026年03月23日 08:53:14 +01:00
Compare
dragonmux approved these changes 2026年03月23日 08:56:39 +01:00
Dismissed
dragonmux left a comment
Copy link

This looks reasonable, merging. Thank you for the contribution and improvement to the Cortex-M support!

(Please rebase on main and we'll get it merged)

This looks reasonable, merging. Thank you for the contribution and improvement to the Cortex-M support! (Please rebase on `main` and we'll get it merged)

(We see you rebased #2215 - please also rebase this PR as we would like to merge this one first.)

(We see you rebased #2215 - please also rebase this PR as we would like to merge this one first.)
mdrssv force-pushed cortexm-halt-poll from 7a1a3e2e55
Some checks are pending
ci/woodpecker/pr/build-firmware/1 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/2 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/3 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/4 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/5 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/6 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/7 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/8 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/9 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/10 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/11 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/12 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/13 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/14 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/15 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/16 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/17 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/18 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/19 Pipeline is pending approval
ci/woodpecker/pr/build-firmware/20 Pipeline is pending approval
ci/woodpecker/pr/build-linux/1 Pipeline is pending approval
ci/woodpecker/pr/build-linux/2 Pipeline is pending approval
ci/woodpecker/pr/build-windows Pipeline is pending approval
to 7d3f92ebfd
Some checks failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
2026年03月23日 09:05:05 +01:00
Compare
@ -527,3 +527,1 @@
const target_halt_reason_e halt_result = target_halt_poll(target, NULL);
/* If we failed to halt the target somehow, bail */
if (halt_result == TARGET_HALT_ERROR || halt_result == TARGET_HALT_RUNNING)
platform_timeout_s timeout;

Because of this variable definition, please drop the one on line 577 to resolve the build error we're seeing in CI

Because of this variable definition, please drop the one on line 577 to resolve the build error we're seeing in CI
mdrssv marked this conversation as resolved
mdrssv force-pushed cortexm-halt-poll from 7d3f92ebfd
Some checks failed
ci/woodpecker/pr/build-firmware/8 Pipeline failed
ci/woodpecker/pr/build-firmware/4 Pipeline failed
ci/woodpecker/pr/build-firmware/1 Pipeline failed
ci/woodpecker/pr/build-firmware/5 Pipeline failed
ci/woodpecker/pr/build-firmware/6 Pipeline failed
ci/woodpecker/pr/build-firmware/3 Pipeline failed
ci/woodpecker/pr/build-firmware/7 Pipeline failed
ci/woodpecker/pr/build-firmware/2 Pipeline failed
ci/woodpecker/pr/build-firmware/10 Pipeline failed
ci/woodpecker/pr/build-firmware/14 Pipeline failed
ci/woodpecker/pr/build-firmware/16 Pipeline failed
ci/woodpecker/pr/build-firmware/11 Pipeline failed
ci/woodpecker/pr/build-firmware/12 Pipeline failed
ci/woodpecker/pr/build-firmware/13 Pipeline failed
ci/woodpecker/pr/build-firmware/9 Pipeline failed
ci/woodpecker/pr/build-firmware/15 Pipeline failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline failed
ci/woodpecker/pr/build-firmware/18 Pipeline failed
ci/woodpecker/pr/build-firmware/20 Pipeline failed
ci/woodpecker/pr/build-firmware/17 Pipeline failed
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
to 6ee78d01c2
Some checks failed
ci/woodpecker/pr/build-linux/1 Pipeline was successful
ci/woodpecker/pr/build-firmware/17 Pipeline was successful
ci/woodpecker/pr/build-firmware/18 Pipeline was successful
ci/woodpecker/pr/build-firmware/20 Pipeline was successful
ci/woodpecker/pr/build-firmware/19 Pipeline was successful
ci/woodpecker/pr/build-linux/2 Pipeline was successful
ci/woodpecker/pr/build-windows Pipeline was successful
ci/woodpecker/push/build-firmware/4 Pipeline was successful
ci/woodpecker/push/build-firmware/3 Pipeline was successful
ci/woodpecker/push/build-firmware/8 Pipeline was successful
ci/woodpecker/push/build-firmware/1 Pipeline was successful
ci/woodpecker/push/build-firmware/5 Pipeline was successful
ci/woodpecker/push/build-firmware/7 Pipeline was successful
ci/woodpecker/push/build-firmware/2 Pipeline was successful
ci/woodpecker/push/build-firmware/6 Pipeline was successful
ci/woodpecker/push/build-firmware/9 Pipeline was successful
ci/woodpecker/push/build-firmware/12 Pipeline was successful
ci/woodpecker/push/build-firmware/14 Pipeline was successful
ci/woodpecker/push/build-firmware/13 Pipeline failed
ci/woodpecker/push/build-firmware/11 Pipeline was successful
ci/woodpecker/push/build-firmware/15 Pipeline was successful
ci/woodpecker/push/build-firmware/16 Pipeline was successful
ci/woodpecker/push/build-firmware/17 Pipeline was successful
ci/woodpecker/push/build-firmware/10 Pipeline was successful
ci/woodpecker/push/build-linux/1 Pipeline was successful
ci/woodpecker/push/build-linux/2 Pipeline was successful
ci/woodpecker/push/build-firmware/19 Pipeline was successful
ci/woodpecker/push/build-firmware/20 Pipeline was successful
ci/woodpecker/push/build-firmware/18 Pipeline was successful
ci/woodpecker/push/build-windows Pipeline was successful
2026年03月23日 09:13:07 +01:00
Compare
mdrssv dismissed dragonmux's review 2026年03月23日 09:13:08 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2214
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "mdrssv/blackmagic:cortexm-halt-poll"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?