Detailed description
While figuring out the details for #2209 and hitting an ASAN crash in BMDA, we noticed there were some lints that were trivially fixed which solve some conversion mis-steps and improve the correctness of the probe finding process by helping prevent allocations getting pointers dropped without free()'ing them. This PR is built from those improvements.
There is still a path through process_vid_pid_table_probe() that according to the static analyser can drop the 4 string pointers this concerns, however we have not yet figured out exactly how this can actually happen to resolve that for the analysis. and fully fix that lint.
Your checklist for this pull request
- I've read the Code of Conduct
- I've read the guidelines for contributing to this repository
- It builds for hardware native (see Building the firmware)
- It builds as BMDA (see Building the BMDA)
- I've tested it to the best of my ability
- My commit messages provide a useful short description of what the commits do
Closing issues
<!-- Filling this template is mandatory -->
## Detailed description
While figuring out the details for #2209 and hitting an ASAN crash in BMDA, we noticed there were some lints that were trivially fixed which solve some conversion mis-steps and improve the correctness of the probe finding process by helping prevent allocations getting pointers dropped without `free()`'ing them. This PR is built from those improvements.
There is still a path through process_vid_pid_table_probe() that according to the static analyser can drop the 4 string pointers this concerns, however we have not yet figured out exactly how this can actually happen to resolve that for the analysis. and fully fix that lint.
## Your checklist for this pull request
* [x] I've read the [Code of Conduct](https://codeberg.org/blackmagic-debug/blackmagic/src/CODE_OF_CONDUCT.md)
* [x] I've read the [guidelines for contributing](https://codeberg.org/blackmagic-debug/blackmagic/src/CONTRIBUTING.md) to this repository
* [x] It builds for hardware native (see [Building the firmware](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-the-firmware))
* [x] It builds as BMDA (see [Building the BMDA](https://codeberg.org/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app))
* [x] I've tested it to the best of my ability
* [x] My commit messages provide a useful short description of what the commits do
## Closing issues
<!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->