7
31
Fork
You've already forked blackmagic
23

ch32f1: Fixed hanging gdb load command for CH32F103C8T6 MCU's #2191

Merged
lasutek merged 1 commit from fix/ch32f1-missing-not-operator into main 2026年02月09日 00:26:28 +01:00
lasutek commented 2026年02月09日 00:16:13 +01:00 (Migrated from github.com)
Copy link

Detailed description

It looks like a bug did slip into the code during refactoring of file src/target/ch32f1.c (commit 85cade5925).

Fix: Added missing logical not operator (!) to function ch32f1_flash_eop_wait().

Your checklist for this pull request

Closing issues

<!-- Filling this template is mandatory --> ## Detailed description It looks like a bug did slip into the code during refactoring of file src/target/ch32f1.c (commit 85cade59259dec2c170fd1225b545c9a4ff163ef). Fix: Added missing logical not operator (!) to function ch32f1_flash_eop_wait(). <!-- Explain the **details** for making this change. * Is a new feature implemented? * What existing problem(s) does the pull request solve? * How does the pull request solve these problems? Please provide enough information so that others can review your pull request. Information embedded in the description part of the commits doesn't count. --> ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues <!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->
dragonmux left a comment
Copy link

LGTM, merging. Thank you for the contribution! You are indeed correct that check was supposed to loop while EOP is not set.

LGTM, merging. Thank you for the contribution! You are indeed correct that check was supposed to loop while EOP is not set.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2191
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "fix/ch32f1-missing-not-operator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?